From owner-dev-commits-src-all@freebsd.org Fri Jan 8 16:43:22 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 854084CEBAF; Fri, 8 Jan 2021 16:43:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DC86y3Lz1z4chF; Fri, 8 Jan 2021 16:43:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 5B97226906; Fri, 8 Jan 2021 16:43:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 108GhMsx014147; Fri, 8 Jan 2021 16:43:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 108GhMvn014146; Fri, 8 Jan 2021 16:43:22 GMT (envelope-from git) Date: Fri, 8 Jan 2021 16:43:22 GMT Message-Id: <202101081643.108GhMvn014146@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kyle Evans Subject: git: 9be9771c8752 - main - efidev: remove EFIIOC_GET_TABLE ioctl MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9be9771c875259b9c99414feb3833c5af03baa8b Auto-Submitted: auto-generated X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jan 2021 16:43:22 -0000 The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=9be9771c875259b9c99414feb3833c5af03baa8b commit 9be9771c875259b9c99414feb3833c5af03baa8b Author: Kyle Evans AuthorDate: 2021-01-07 21:51:18 +0000 Commit: Kyle Evans CommitDate: 2021-01-08 16:41:50 +0000 efidev: remove EFIIOC_GET_TABLE ioctl This ioctl would instantly induce a panic, likely since near inception, up until 0861c7d3e048. Lack of previous interest in fixing it combined with the problematic interface (exports a pointer, really a physical address) brings us to the natural conclusion: remove it until a useful consumer forward. If it eventually gets resurrected, the interface should definitely not return in this exact form and likely needs to be reimagined. The associated KPI, efi_get_table, is left intact for the time being. Reviewed by: imp, jrtc27 Also discussed with: brooks, jhb Differential Revision: https://reviews.freebsd.org/D28030 --- sys/dev/efidev/efidev.c | 8 -------- sys/sys/efiio.h | 7 ------- 2 files changed, 15 deletions(-) diff --git a/sys/dev/efidev/efidev.c b/sys/dev/efidev/efidev.c index b585db4f0117..303b10c1d0ba 100644 --- a/sys/dev/efidev/efidev.c +++ b/sys/dev/efidev/efidev.c @@ -53,14 +53,6 @@ efidev_ioctl(struct cdev *dev __unused, u_long cmd, caddr_t addr, int error; switch (cmd) { - case EFIIOC_GET_TABLE: - { - struct efi_get_table_ioc *egtioc = - (struct efi_get_table_ioc *)addr; - - error = efi_get_table(&egtioc->uuid, &egtioc->ptr); - break; - } case EFIIOC_GET_TIME: { struct efi_tm *tm = (struct efi_tm *)addr; diff --git a/sys/sys/efiio.h b/sys/sys/efiio.h index 87fed9c3afd8..e5a0763536a3 100644 --- a/sys/sys/efiio.h +++ b/sys/sys/efiio.h @@ -32,12 +32,6 @@ #include #include -struct efi_get_table_ioc -{ - struct uuid uuid; /* UUID to look up */ - void *ptr; /* Pointer to table in KVA space */ -}; - struct efi_var_ioc { efi_char *name; /* User pointer to name, in wide chars */ @@ -48,7 +42,6 @@ struct efi_var_ioc size_t datasize; /* Number of *bytes* in the data */ }; -#define EFIIOC_GET_TABLE _IOWR('E', 1, struct efi_get_table_ioc) #define EFIIOC_GET_TIME _IOR('E', 2, struct efi_tm) #define EFIIOC_SET_TIME _IOW('E', 3, struct efi_tm) #define EFIIOC_VAR_GET _IOWR('E', 4, struct efi_var_ioc)