From owner-freebsd-current Tue Oct 24 11: 3:31 2000 Delivered-To: freebsd-current@freebsd.org Received: from critter.freebsd.dk (flutter.freebsd.dk [212.242.40.147]) by hub.freebsd.org (Postfix) with ESMTP id ECB5737B479 for ; Tue, 24 Oct 2000 11:03:27 -0700 (PDT) Received: from critter (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.1/8.9.3) with ESMTP id e9OIKVU21002; Tue, 24 Oct 2000 20:20:31 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: "Justin T. Gibbs" Cc: current@FreeBSD.ORG Subject: Re: Review: offsetof//fldoff patch. In-Reply-To: Your message of "Tue, 24 Oct 2000 11:51:29 MDT." <200010241751.e9OHpTm04956@aslan.scsiguy.com> Date: Tue, 24 Oct 2000 20:20:31 +0200 Message-ID: <21000.972411631@critter> From: Poul-Henning Kamp Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <200010241751.e9OHpTm04956@aslan.scsiguy.com>, "Justin T. Gibbs" wri tes: >> >>Please test & review this patch: >> >> http://phk.freebsd.dk/patch/offsetof.patch > >I believe that several drivers include stddef.h to get >offsetof. I think most of these files are flagged by >"/* for offsetof */". Right, in fact there are many such, and they should be cleaned up as well, but right now I want to keep this patch at a manageable impact. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message