From owner-svn-ports-all@freebsd.org Wed Apr 18 08:21:27 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8C8CCF9E967; Wed, 18 Apr 2018 08:21:27 +0000 (UTC) (envelope-from adridg@freebsd.org) Received: from smtp03.mail.online.nl (smtp03.mail.online.nl [194.134.25.73]) by mx1.freebsd.org (Postfix) with ESMTP id 2E9F987925; Wed, 18 Apr 2018 08:21:27 +0000 (UTC) (envelope-from adridg@freebsd.org) Received: from beastie.bionicmutton.org (s55969a9e.adsl.online.nl [85.150.154.158]) by smtp03.mail.online.nl (Postfix) with ESMTP id EC26A1C0033; Wed, 18 Apr 2018 10:21:21 +0200 (CEST) From: Adriaan de Groot To: Mathieu Arnold Cc: "Jason E. Hale" , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r467663 - in head/audio: . liblastfm liblastfm-qt5 liblastfm/files Date: Wed, 18 Apr 2018 10:21:16 +0200 Message-ID: <3174473.pFhRGbBKQR@beastie.bionicmutton.org> Organization: FreeBSD In-Reply-To: <20180418080556.lh6ds7t6e34ackoi@atuin.in.mat.cc> References: <201804172327.w3HNRLIF044763@repo.freebsd.org> <20180418080556.lh6ds7t6e34ackoi@atuin.in.mat.cc> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3590245.hK24rM1CB7"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2018 08:21:27 -0000 --nextPart3590245.hK24rM1CB7 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Wednesday, 18 April 2018 10:05:56 CEST Mathieu Arnold wrote: > On Tue, Apr 17, 2018 at 11:27:21PM +0000, Jason E. Hale wrote: > > Log: > > - Update audio/liblastfm to 1.0.9-5-g4433165 [1] > > - Add audio/liblastfm-qt5 slave port which provides a Qt 5 interface [1] > > Why not add flavors instead of a slave port? In an existing review https://reviews.freebsd.org/D14660 you (Mat) say of a different port """We currently do not accept flavors that add new packages though, so this change will be able to go in when ports-mgmt/poudriere is updated to 3.3.""" That would preclude flavorizing liblastfm, wouldn't it? There are a lot of Qt4/ Qt5 ports that could be flavorized and/or swept together like that. [ade] --nextPart3590245.hK24rM1CB7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iHUEABEIAB0WIQTVFBoRsP760fy+Jisy7lRaPghTTwUCWtb//AAKCRAy7lRaPghT T//FAQC3ytzphYIZBoxcj56EJR8ljaadlJ0IMyBmb93UF6ylbQEAu7znGpmOqBOI +2Qs5QYWsntg0pyS16Fzyqsc78D0n2Q= =Lo/a -----END PGP SIGNATURE----- --nextPart3590245.hK24rM1CB7--