From owner-freebsd-hackers@FreeBSD.ORG Sat Jan 24 08:25:00 2015 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 843317B1; Sat, 24 Jan 2015 08:25:00 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E692D166; Sat, 24 Jan 2015 08:24:59 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id t0O8Oo5R010802 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 24 Jan 2015 10:24:50 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t0O8Oo5R010802 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id t0O8Oo3Z010801; Sat, 24 Jan 2015 10:24:50 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 24 Jan 2015 10:24:49 +0200 From: Konstantin Belousov To: Ryan Stone Subject: Re: Sleeping thread held mutex in vm_pageout_oom() Message-ID: <20150124082449.GM42409@kib.kiev.ua> References: <20150120083212.GC42409@kib.kiev.ua> <20150122083514.GU42409@kib.kiev.ua> <20150123083654.GB42409@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: "freebsd-hackers@freebsd.org" , Ed Maste X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Jan 2015 08:25:00 -0000 On Fri, Jan 23, 2015 at 07:30:06PM -0500, Ryan Stone wrote: > On Fri, Jan 23, 2015 at 10:24 AM, Ed Maste wrote: > > It does say that the braces "may be" left out though, and I much > > prefer the guideline as you state it. > > That works for me. > > The WITNESS_WARN() survived a buildworld, so I'll commit that once kib > gets the vm_pageout_oom() fix in I thought that you intend to commit the fix ? This is what I read from your response to the latest patch, and I replied that I agree.