Date: Fri, 2 Nov 2012 09:01:56 -0500 From: Eric van Gyzen <eric@vangyzen.net> To: Alfred Perlstein <alfred@ixsystems.com> Cc: mav@freebsd.org, hackers@freebsd.org Subject: Re: please review: patch to retain device name for dumpdev. Message-ID: <5093D254.5010702@vangyzen.net> In-Reply-To: <50921B44.20400@ixsystems.com> References: <50921B44.20400@ixsystems.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/01/2012 01:48, Alfred Perlstein wrote:
> /* Registration of dumpers */
> int
> -set_dumper(struct dumperinfo *di)
> +set_dumper(struct dumperinfo *di, const char *devname)
> {
>
> if (di == NULL) {
> bzero(&dumper, sizeof dumper);
> + dumpdevname[0] = '\0';
> return (0);
> }
> if (dumper.dumper != NULL)
> return (EBUSY);
> dumper = *di;
> + strlcpy(dumpdevname, devname, sizeof(dumpdevname));
> + if (strlen(dumpdevname) != strlen(devname)) {
You can use the return value of strlcpy() to test for truncation, and
save two strlen()s:
if (strlcpy(...) >= sizeof(dst)) { /* truncated */ }
> + printf("set_dumper: device name truncated from '%s' -> '%s'\n",
> + devname, dumpdevname);
> + }
> return (0);
> }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5093D254.5010702>