From owner-freebsd-ports-bugs@FreeBSD.ORG  Sat Nov 20 15:40:13 2010
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 066601065693
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Sat, 20 Nov 2010 15:40:13 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id E90128FC0A
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Sat, 20 Nov 2010 15:40:12 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oAKFeC0E098214
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Sat, 20 Nov 2010 15:40:12 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oAKFeCBP098213;
	Sat, 20 Nov 2010 15:40:12 GMT (envelope-from gnats)
Date: Sat, 20 Nov 2010 15:40:12 GMT
Message-Id: <201011201540.oAKFeCBP098213@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
From: Chris Rees <utisoft@gmail.com>
Cc: 
Subject: Re: ports/148777: [New Port] sysutils/qjail: Utility to deploy large
 number of jails quickly
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Chris Rees <utisoft@gmail.com>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 20 Nov 2010 15:40:13 -0000

The following reply was made to PR ports/148777; it has been noted by GNATS.

From: Chris Rees <utisoft@gmail.com>
To: bug-followup@freebsd.org, joeb@a1poweruser.com
Cc:  
Subject: Re: ports/148777: [New Port] sysutils/qjail: Utility to deploy large
 number of jails quickly
Date: Sat, 20 Nov 2010 15:39:30 +0000

 Read the Porter's Handbook again, and look at the pointers here:
 
 I suggest you remove the redundant DISTFILES line, and then read
 http://www.freebsd.org/doc/en/books/porters-handbook/plist-config.html
 
 Also don't use spaces in Makefiles; use tabs. That's an error.
 
 Then read: http://www.freebsd.org/doc/en/books/porters-handbook/rc-scripts.html
 
 Also don't edit files not in PREFIX; you can't be messing with /etc/rc.d
 
 Run make makesum when you're done -- you must have a distinfo
 
 Take the & out of the COMMENT and replace it with and (you have enough space)
 
 Why are you using ${CP} and ${INSTALL_DATA}? Why not just the one? Also;
 
 X        ${CP}             ${WRKSRC}/qjail.8            ${PREFIX}/man/man8/
 X        ${CP}             ${WRKSRC}/qjail-intro.8      ${PREFIX}/man/man8/
 X        ${CP}             ${WRKSRC}/qjail.conf.8       ${PREFIX}/man/man8/
 
 you should be using ${MANPREFIX} here.
 
 pkg-descr is quite long; and you should remove the newlines at the end
 of pkg-descr
 
 Take out the extraneous newlines in the COMMENT/MAINTAINER block.
 
 Then run portlint -A over it (you should obviously install portlint first).
 
 Good luck!
 
 Chris