Date: Sat, 20 Nov 2010 15:40:12 GMT From: Chris Rees <utisoft@gmail.com> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/148777: [New Port] sysutils/qjail: Utility to deploy large number of jails quickly Message-ID: <201011201540.oAKFeCBP098213@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/148777; it has been noted by GNATS. From: Chris Rees <utisoft@gmail.com> To: bug-followup@freebsd.org, joeb@a1poweruser.com Cc: Subject: Re: ports/148777: [New Port] sysutils/qjail: Utility to deploy large number of jails quickly Date: Sat, 20 Nov 2010 15:39:30 +0000 Read the Porter's Handbook again, and look at the pointers here: I suggest you remove the redundant DISTFILES line, and then read http://www.freebsd.org/doc/en/books/porters-handbook/plist-config.html Also don't use spaces in Makefiles; use tabs. That's an error. Then read: http://www.freebsd.org/doc/en/books/porters-handbook/rc-scripts.html Also don't edit files not in PREFIX; you can't be messing with /etc/rc.d Run make makesum when you're done -- you must have a distinfo Take the & out of the COMMENT and replace it with and (you have enough space) Why are you using ${CP} and ${INSTALL_DATA}? Why not just the one? Also; X ${CP} ${WRKSRC}/qjail.8 ${PREFIX}/man/man8/ X ${CP} ${WRKSRC}/qjail-intro.8 ${PREFIX}/man/man8/ X ${CP} ${WRKSRC}/qjail.conf.8 ${PREFIX}/man/man8/ you should be using ${MANPREFIX} here. pkg-descr is quite long; and you should remove the newlines at the end of pkg-descr Take out the extraneous newlines in the COMMENT/MAINTAINER block. Then run portlint -A over it (you should obviously install portlint first). Good luck! Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201011201540.oAKFeCBP098213>