From owner-svn-src-all@FreeBSD.ORG Sun May 11 12:53:52 2014 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9787B188; Sun, 11 May 2014 12:53:52 +0000 (UTC) Received: from mho-01-ewr.mailhop.org (mho-03-ewr.mailhop.org [204.13.248.66]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6B35E209F; Sun, 11 May 2014 12:53:51 +0000 (UTC) Received: from c-24-8-230-52.hsd1.co.comcast.net ([24.8.230.52] helo=damnhippie.dyndns.org) by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1WjTGI-000Lz8-Ik; Sun, 11 May 2014 12:53:50 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id s4BCrk7o032825; Sun, 11 May 2014 06:53:46 -0600 (MDT) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 24.8.230.52 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19QFlZpjGOKp2GP03BWPatk Subject: Re: svn commit: r265861 - in head/sys: arm/include modules From: Ian Lepore To: Konstantin Belousov In-Reply-To: <20140511071002.GV74331@kib.kiev.ua> References: <201405110043.s4B0h6B9040965@svn.freebsd.org> <20140511071002.GV74331@kib.kiev.ua> Content-Type: text/plain; charset="us-ascii" Date: Sun, 11 May 2014 06:53:46 -0600 Message-ID: <1399812826.22079.427.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 May 2014 12:53:52 -0000 On Sun, 2014-05-11 at 10:10 +0300, Konstantin Belousov wrote: > On Sun, May 11, 2014 at 12:43:06AM +0000, Ian Lepore wrote: > > Author: ian > > Date: Sun May 11 00:43:06 2014 > > New Revision: 265861 > > URL: http://svnweb.freebsd.org/changeset/base/265861 > > > > Log: > > Make the hardware memory and instruction barrier functions work on armv4 > > and armv5 as well. > > > > Modified: > > head/sys/arm/include/atomic.h > > head/sys/modules/Makefile > > > > Modified: head/sys/arm/include/atomic.h > > ============================================================================== > > --- head/sys/arm/include/atomic.h Sat May 10 22:27:01 2014 (r265860) > > +++ head/sys/arm/include/atomic.h Sun May 11 00:43:06 2014 (r265861) > > @@ -58,9 +58,9 @@ > > #define dsb() __asm __volatile("mcr p15, 0, %0, c7, c10, 4" : : "r" (0) : "memory") > > #define dmb() __asm __volatile("mcr p15, 0, %0, c7, c10, 5" : : "r" (0) : "memory") > > #else > > -#define isb() > > -#define dsb() > > -#define dmb() > > +#define isb() __asm __volatile("mcr p15, 0, %0, c7, c5, 4" : : "r" (0) : "memory") > > +#define dsb() __asm __volatile("mcr p15, 0, %0, c7, c10, 4" : : "r" (0) : "memory") > > +#define dmb() dsb() > > #endif > > > > #define mb() dmb() > > > > Modified: head/sys/modules/Makefile > > ============================================================================== > > --- head/sys/modules/Makefile Sat May 10 22:27:01 2014 (r265860) > > +++ head/sys/modules/Makefile Sun May 11 00:43:06 2014 (r265861) > > @@ -2,6 +2,8 @@ > > > > .include > > > > +SUBDIR_PARALLEL= > > + > > # Modules that include binary-only blobs of microcode should be selectable by > > # MK_SOURCELESS_UCODE option (see below). > > > This part is unrelated and should be reverted, I suppose ? Ooops, indeed, thanks. Although... it's a good change in terms of speeding up the build, I just didn't intend to commit it until it got tested with -j levels higher than I can test with my little 6-core machine. -- Ian