From owner-freebsd-fs@FreeBSD.ORG Fri Nov 5 21:16:16 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D6BDD106564A; Fri, 5 Nov 2010 21:16:16 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from esa-jnhn.mail.uoguelph.ca (esa-jnhn.mail.uoguelph.ca [131.104.91.44]) by mx1.freebsd.org (Postfix) with ESMTP id 70D9A8FC0A; Fri, 5 Nov 2010 21:16:16 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApwEAGYR1EyDaFvO/2dsb2JhbACDKJ80qwOQboJ0gWFzBIpW X-IronPort-AV: E=Sophos;i="4.58,305,1286164800"; d="scan'208";a="99793894" Received: from erie.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca) ([131.104.91.206]) by esa-jnhn-pri.mail.uoguelph.ca with ESMTP; 05 Nov 2010 17:16:04 -0400 Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1]) by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id 173D7B3F56; Fri, 5 Nov 2010 17:16:04 -0400 (EDT) Date: Fri, 5 Nov 2010 17:16:04 -0400 (EDT) From: Rick Macklem To: Andriy Gapon Message-ID: <1090600565.181851.1288991764084.JavaMail.root@erie.cs.uoguelph.ca> In-Reply-To: <4CD3B4A0.6060207@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_181850_1076044894.1288991764083" X-Originating-IP: [99.225.56.115] X-Mailer: Zimbra 6.0.7_GA_2476.RHEL4 (ZimbraWebClient - IE8 (Win)/6.0.7_GA_2473.RHEL4_64) Cc: freebsd-fs@freebsd.org, freebsd-current@freebsd.org Subject: Re: processes stuck on a vnode lock X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Nov 2010 21:16:16 -0000 ------=_Part_181850_1076044894.1288991764083 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit > on 04/11/2010 16:45 Andriy Gapon said the following: > > on 04/11/2010 09:49 Andriy Gapon said the following: > >> > >> I see a few processes stuck on the same vnode, trying to take or to > >> upgrade to > >> an exclusive lock on it, while the lock data suggests that it is > >> already > >> shared-locked. The vnode is a root vnode of one of ZFS filesystems > >> (it's not a > >> global root). > >> > >> I couldn't find any (other) threads that could actually hold the > >> vnode lock, but > >> lock shared count is suspiciously or coincidentally the same as > >> number of > >> threads in zfs_root call. > > > > BTW, I still have the system alive and online, so if anyone has > > ideas I can try them. > > > > The kernel is not live now, but I have saved it and vmcore of the > system. > > Kostik, > > just a pure guesswork here - could r214049 have something to do with > this? > I looked at the change and it looks completely correct - I don't think > that a > vnode lock can be leaked by that code. But, OTOH, it has some special > handling > for VV_ROOT, it's in NFS code and and it's in a right time-frame, so > just asking. > You could try the attached patch which seems to have worked for Josh Carroll, who had a similar problem with stable/8. rick ------=_Part_181850_1076044894.1288991764083 Content-Type: text/x-patch; name=nfs_serv.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=nfs_serv.patch LS0tIG5mc19zZXJ2LmMuc2F2CTIwMTAtMTEtMDUgMDg6MTU6NTcuMDAwMDAwMDAwIC0wNDAwCisr KyBuZnNfc2Vydi5jCTIwMTAtMTEtMDUgMDg6MTg6NDAuMDAwMDAwMDAwIC0wNDAwCkBAIC0zMjUy LDcgKzMyNTIsNyBAQAogCQkJbmZocC0+ZmhfZnNpZCA9IG52cC0+dl9tb3VudC0+bW50X3N0YXQu Zl9mc2lkOwogCQkJaWYgKChlcnJvcjEgPSBWT1BfVlBUT0ZIKG52cCwgJm5maHAtPmZoX2ZpZCkp ID09IDApCiAJCQkJZXJyb3IxID0gVk9QX0dFVEFUVFIobnZwLCB2YXAsIGNyZWQpOwotCQkJaWYg KHZwID09IG52cCkKKwkJCWlmICh1c2V2Z2V0ID09IDAgJiYgdnAgPT0gbnZwKQogCQkJCXZ1bnJl ZihudnApOwogCQkJZWxzZQogCQkJCXZwdXQobnZwKTsK ------=_Part_181850_1076044894.1288991764083--