From owner-freebsd-arch@FreeBSD.ORG  Wed Mar 24 19:23:50 2010
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1695B106566B;
	Wed, 24 Mar 2010 19:23:50 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id DA6B08FC08;
	Wed, 24 Mar 2010 19:23:49 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id 7366346B53;
	Wed, 24 Mar 2010 15:23:49 -0400 (EDT)
Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9])
	by bigwig.baldwin.cx (Postfix) with ESMTPA id AC8C98A01F;
	Wed, 24 Mar 2010 15:23:48 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Alexander Leidinger <Alexander@leidinger.net>
Date: Wed, 24 Mar 2010 11:32:29 -0400
User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; )
References: <20100322.125937.278730673160410010.imp@bsdimp.com>
	<201003241005.55239.jhb@freebsd.org>
	<20100324154214.16865r6wk0r22rcw@webmail.leidinger.net>
In-Reply-To: <20100324154214.16865r6wk0r22rcw@webmail.leidinger.net>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201003241132.29588.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(bigwig.baldwin.cx); Wed, 24 Mar 2010 15:23:48 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-1.7 required=4.2 tests=AWL,BAYES_00,
	DATE_IN_PAST_03_06 autolearn=no version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx
Cc: rwatson@freebsd.org, freebsd-arch@freebsd.org
Subject: Re: CTF patch for testing/review
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Mar 2010 19:23:50 -0000

On Wednesday 24 March 2010 10:42:14 am Alexander Leidinger wrote:
> Quoting John Baldwin <jhb@freebsd.org> (from Wed, 24 Mar 2010 10:05:55 
-0400):
> 
> > On Wednesday 24 March 2010 9:59:41 am Alexander Leidinger wrote:
> 
> >> Currently I have the problem that WITH_CTF is not picked up by kmod.mk
> >> if "makeoptions WITH_CTF=yes" is used in the kernel config. This means
> >> that all makeoptions do not propagate to module builds.
> >>
> >> Any ideas?
> >
> > Hmmmm.  That's odd because 'DEBUG=-g' does work.  Ah, I think you should
> > patch kern.post.mk to propogate WITH_CTF to modules.  This is how it works
> > for DEBUG now:
> >
> > .if defined(DEBUG)
> > MKMODULESENV+=  DEBUG_FLAGS="${DEBUG}"
> > .endif
> 
> Do we want to be able to override WITH_CTF in modules (-> kern.pre.mk  
> instead of kernl.post.mk)?

No, I think it is fine to treat it the same as DEBUG.

> While I'm here, do we want to have CONF_CFLAGS used in modules too? I  
> would expect that they are used there (I use it to use -fno-builtin  
> for my kernel build) and would put it into kern.post.mk.

Hmm, probably yes.  That should be a separate commit however.

-- 
John Baldwin