From owner-cvs-all@FreeBSD.ORG Mon Nov 5 19:51:13 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9C92316A417; Mon, 5 Nov 2007 19:51:13 +0000 (UTC) (envelope-from kan@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6DEFB13C480; Mon, 5 Nov 2007 19:51:13 +0000 (UTC) (envelope-from kan@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id lA5JpDEb018389; Mon, 5 Nov 2007 19:51:13 GMT (envelope-from kan@repoman.freebsd.org) Received: (from kan@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id lA5JpDr6018384; Mon, 5 Nov 2007 19:51:13 GMT (envelope-from kan) Message-Id: <200711051951.lA5JpDr6018384@repoman.freebsd.org> From: Alexander Kabaev Date: Mon, 5 Nov 2007 19:51:12 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/usb ukbd.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Nov 2007 19:51:13 -0000 kan 2007-11-05 19:51:12 UTC FreeBSD src repository Modified files: sys/dev/usb ukbd.c Log: Do not pass an address to local stack variable to usbd_set_report_async. Allocate space in keyboard state structure instead to prevent random byte from possibly overwritten stack location frombeing shoved into USB device when transfer actually takes place. This fixes at least one instance of LEDs not working with USB keyboards. Revision Changes Path 1.75 +4 -3 src/sys/dev/usb/ukbd.c