From nobody Fri May 22 17:58:11 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gMY0g2f2Dz6fLld for ; Fri, 22 May 2026 17:58:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gMY0g0VCdz4MnM for ; Fri, 22 May 2026 17:58:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779472691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=if+PIIYL09yfHnjYdgT77yQiPd45X5fFB7PfwYg0B8Y=; b=QuI3z7BYQRn/nUEDnAhIw6tPynU37+vxdcY0tjouw3ItyoCk2tLSMmEzmnFIT7V8pxfq1o spvMpHrBTPaewIl01LrA7xqJPKwsVsr4beTvAGqJHApHvrMejrM+Kp1PTppVpYVvgI0W8p zxgdsMNMc/QYTzwnQeKBUP4quQQurXaGGejAvLXIeU2Pk0r+o9j6HKpPoO/fBHhGWfrsSM bFp/oNOM3cxYJtEaDlYAmeYCy2pNlQzxOsqrnBV8gcVL/R2cMcDLAMELs2lf9RIoHx1yUf jf8zT0pa2ciddZ5D5mlGGdxnjf4j9Hsmd3y1Re2nLs9uZXjLbImswFIPjbL3vQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779472691; a=rsa-sha256; cv=none; b=geBy00CamjktvW4ZpYFGL4IQXJ/m0kJXe1aYM8fyJmQlfezfjKK0gE0xb8TymkzV9kepUJ 6B1X1m/4S+0YH31YX3MMO2e26PL9W0PUQ2RrGS1DMHdJw4FDTsv2ulQ8G1qbbSdCIGEVlw MOUdyS44pEOUplbsXtUReM4qamUwvWOvQFUE2yqzeVNkRcBnEf+Gg2G71EHVbBMgbT/L8p CAbacRbAl1LB/qR65LIunFW0csMv+HqcNhN/W0Nhk3jr/zQkq9M5/FL2HgGgfR9eoyVeac 3Hk4LnqNLdIbes9N6Eie1nLCqlby08uVZDsdL1RsTqmHXQFzAbTQMkEeDpeAGw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779472691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=if+PIIYL09yfHnjYdgT77yQiPd45X5fFB7PfwYg0B8Y=; b=UNu/soWCYEY+SOnOcFFGW3+HWW85u/96GIeKj8ElPf1vyy3Y7BDvw3WPdkVgh8YWyRXhgt +BauuPtHXmqD0c0p2jFI48O4Jm56bI+jMUgfrbcu4S3Mu3uSGlpkVERGfOoopwYq0M3xZK 5ehwl5D3dj1ExWtK3zJVOvwkXi4wosj9k3X8MFunF0SA67+KTSrNBDYs2OHcxHPCUELwXl ErgIhHa6I3elZJt6hsQVO1C5GeKuo7++m/bBu5GI8Zt9IWrYiUlZiOobTOzd18UEUQczE9 ro+03xaDyoczZV1QU26OA4z7L0sekLUsnEBSkk1EMXhQjsbbERZAK6MvZreU/w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gMY0g0678zXTc for ; Fri, 22 May 2026 17:58:11 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3948e by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 22 May 2026 17:58:11 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: b94689d036c5 - main - tftp: Add test case with over-long URL List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b94689d036c5f5bdc04d080ff7dd5d0e9df9b8d4 Auto-Submitted: auto-generated Date: Fri, 22 May 2026 17:58:11 +0000 Message-Id: <6a109933.3948e.12359126@gitrepo.freebsd.org> The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=b94689d036c5f5bdc04d080ff7dd5d0e9df9b8d4 commit b94689d036c5f5bdc04d080ff7dd5d0e9df9b8d4 Author: Dag-Erling Smørgrav AuthorDate: 2026-05-22 17:57:27 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-05-22 17:57:27 +0000 tftp: Add test case with over-long URL This adds a test case that passes a very long URL on the command line, which would previously have resulted in a benign buffer overflow in urihandling(), detectable only by compiling tftp with ASAN enabled. MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D57074 --- usr.bin/tftp/tests/tftp_test.sh | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/usr.bin/tftp/tests/tftp_test.sh b/usr.bin/tftp/tests/tftp_test.sh index a4c9f3b898e7..12c008b2c78c 100644 --- a/usr.bin/tftp/tests/tftp_test.sh +++ b/usr.bin/tftp/tests/tftp_test.sh @@ -442,6 +442,29 @@ tftp_url_ipv6_cleanup() { stop_tftpd } +atf_test_case tftp_url_long cleanup +tftp_url_long_head() { + atf_set "descr" "Very long URL" + atf_set "require.user" "root" +} +tftp_url_long_body() { + start_tftpd + mkdir "${tftp_dir}/subdirectory" + local remote_file="${tftp_dir}/hello.txt" + echo "Hello, $$!" >"${remote_file}" + local local_file="${remote_file##*/}" + local d="subdirectory/../" + d="${d}${d}${d}${d}${d}${d}${d}${d}" + d="${d}${d}${d}${d}${d}${d}${d}${d}" + d="${d}${d}${d}${d}${d}${d}${d}${d}" + atf_check -s exit:1 -o match:"Illegal TFTP operation" \ + tftp "tftp://localhost/${d}${remote_file##*/}" + atf_check -s exit:1 test -f "${local_file}" +} +tftp_url_long_cleanup() { + stop_tftpd +} + atf_init_test_cases() { atf_add_test_case tftp_get_big atf_add_test_case tftp_get_host @@ -462,4 +485,5 @@ atf_init_test_cases() { atf_add_test_case tftp_url_host atf_add_test_case tftp_url_ipv4 atf_add_test_case tftp_url_ipv6 + atf_add_test_case tftp_url_long }