From owner-svn-ports-head@freebsd.org Sun Jul 7 11:24:24 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F2B5B15E2303; Sun, 7 Jul 2019 11:24:23 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 89D2A82441; Sun, 7 Jul 2019 11:24:22 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id 0A6B034057; Sun, 7 Jul 2019 07:24:11 -0400 (EDT) Received: from anthias (ip-109-40-2-148.web.vodafone.de [109.40.2.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id E8C8834056; Sun, 7 Jul 2019 07:24:09 -0400 (EDT) Date: Sun, 7 Jul 2019 13:24:00 +0200 (CEST) From: Gerald Pfeifer To: "Matthew D. Fuller" cc: Niclas Zeising , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r479538 - in head: Mk audio/clementine-player audio/dpf-plugins-lv2 audio/gogglesmm audio/mixxx audio/rhythmbox audio/x42-plugins-lv2 cad/brlcad cad/freecad cad/kicad cad/kicad-devel ca... In-Reply-To: <20180912133527.GL71859@over-yonder.net> Message-ID: References: <201809111834.w8BIYS9X092959@repo.freebsd.org> <20180912133527.GL71859@over-yonder.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 89D2A82441 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of gerald@pfeifer.com designates 209.68.5.143 as permitted sender) smtp.mailfrom=gerald@pfeifer.com X-Spamd-Result: default: False [-1.39 / 15.00]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_XBL(3.00)[148.2.40.109.zen.spamhaus.org : 127.0.0.4]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(0.00)[+a:hamza.pair.com]; NEURAL_HAM_LONG(-0.99)[-0.988,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[pfeifer.com]; NEURAL_HAM_MEDIUM(-0.93)[-0.934,0]; RCPT_COUNT_FIVE(0.00)[5]; BAD_REP_POLICIES(0.10)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[mailwash29.pair.com]; NEURAL_HAM_SHORT(-0.35)[-0.347,0]; RCVD_IN_DNSWL_NONE(0.00)[143.5.68.209.list.dnswl.org : 127.0.10.0]; IP_SCORE(-2.11)[ip: (-7.86), ipnet: 209.68.0.0/18(-1.56), asn: 7859(-1.07), country: US(-0.06)]; RECEIVED_SPAMHAUS_PBL(0.00)[148.2.40.109.zen.spamhaus.org : 127.0.0.11]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7859, ipnet:209.68.0.0/18, country:US]; RCVD_TLS_LAST(0.00)[]; FROM_EQ_ENVFROM(0.00)[] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Jul 2019 11:24:24 -0000 On Wed, 12 Sep 2018, Matthew D. Fuller wrote: >> Log: >> Change x11/xorgproto to become a build dep >> [...] >> Bump portrevision on depending ports. > At least x11-servers/xorg-{nestserver,vfbserver} and > x11-servers/xwayland have a .include of xorg-server/Makefile at the > end, which means that their PORTREVISIONs went backward (from 9 to 1) > as a result of this. Since they'll just get it from xorg-server, they > wouldn't need PORTREVISION added anyway. > > (it might be worth a comment in the Makefiles where the PORTREVISION > would be, to add a little guardrail for the future) Agreed. Or, as I see is now the case with x11-servers/xwayland (Thanks!), though not x11-servers/xorg-{nestserver,vfbserver} simply add their own PORTREVISION. PORTREVISION bumps sometimes touch a thousand, or two thousand, or even more ports, and anything that's intricate or easy to miss unfortunately does fare a chance of a mishap taking place. The logic I added to Tools/scripts/bump-revision.sh last year to catch cases of PORTREVISION practically going backwards is a great safety net, but as always: better for a safety net not being used in the first place. ;-) Gerald