From owner-freebsd-doc@FreeBSD.ORG Mon Feb 21 12:30:19 2005 Return-Path: Delivered-To: freebsd-doc@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F00E016A4D0 for ; Mon, 21 Feb 2005 12:30:19 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B905943D48 for ; Mon, 21 Feb 2005 12:30:19 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id j1LCUJLC049232 for ; Mon, 21 Feb 2005 12:30:19 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id j1LCUJjU049231; Mon, 21 Feb 2005 12:30:19 GMT (envelope-from gnats) Date: Mon, 21 Feb 2005 12:30:19 GMT Message-Id: <200502211230.j1LCUJjU049231@freefall.freebsd.org> To: freebsd-doc@FreeBSD.org From: Florent Thoumie Subject: Re: docs/77851: articles/committers-guide: change Approved -> Reviewed X-BeenThere: freebsd-doc@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Florent Thoumie List-Id: Documentation project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2005 12:30:20 -0000 The following reply was made to PR docs/77851; it has been noted by GNATS. From: Florent Thoumie To: "Simon L. Nielsen" Cc: FreeBSD-gnats-submit@FreeBSD.org Subject: Re: docs/77851: articles/committers-guide: change Approved -> Reviewed Date: Mon, 21 Feb 2005 13:24:59 +0100 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig652565EE2E8C582CE3347021 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Simon L. Nielsen wrote: > On 2005.02.21 12:59:15 +0100, Florent Thoumie wrote: > > >>These are two different statements of the Committer's Guide. I think the >>second one is erroneous. > > > It isn't, it's different topics. > > >>"Approved by" is only acceptable from non-mentored src committers -- mentored >>committers can provide a "Reviewed by" but not an "Approved by". > > > This is from the "2.1 Policy for doc/ committer activity in src/" > section, ie. only for doc committers (if they are mentored or not) > and only wrt. commtting to src/. > > >>Until your mentor decides (and announces with a forced commit to access) that >>you have learned the ropes and are ready to commit on your own, you should not >>commit anything without first getting your mentor's review and approval, and >>you should document that approval with an Approved by: line in the commit >>message. > > > This is general for all committers being mentored and is correct > (though not entirely at least wrt. to doc/ people but that's another > matter). Ok this was a bit unclear, though i read these parts 2 or 3 times. Thanks. --------------enig652565EE2E8C582CE3347021 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (FreeBSD) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCGdMfMxEkbVFH3PQRArFEAJ46jgRVamwzkW7V2PjSi4a9gI/2KQCcCGyY pXAFsZZl0J2qvkdZuDaWjR4= =Nqs4 -----END PGP SIGNATURE----- --------------enig652565EE2E8C582CE3347021--