From owner-svn-ports-all@freebsd.org Sun Dec 18 14:26:33 2016 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C85F9C85FF4; Sun, 18 Dec 2016 14:26:33 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (mx3.absolight.net [IPv6:2a01:678:2:100::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "plouf.absolight.net", Issuer "CAcert Class 3 Root" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 839E11750; Sun, 18 Dec 2016 14:26:33 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from prod2.absolight.net (localhost [127.0.0.1]) by prod2.absolight.net (Postfix) with ESMTP id A19D6BDD7E; Sun, 18 Dec 2016 15:26:30 +0100 (CET) Received: from atuin.in.mat.cc (atuin.in.mat.cc [79.143.241.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by prod2.absolight.net (Postfix) with ESMTPSA id 9E6E7BDD72; Sun, 18 Dec 2016 15:26:29 +0100 (CET) Subject: Re: svn commit: r428845 - in head/devel: . py-XStatic py-XStatic-Angular py-XStatic-Angular-Bootstrap py-XStatic-Angular-FileUpload py-XStatic-Angular-Gettext py-XStatic-Angular-Schema-Form py-XStatic-... To: Roman Bogorodskiy References: <201612181136.uBIBaQLG037821@repo.freebsd.org> <56123f95-c5dc-1e3a-3db5-d87043949c45@FreeBSD.org> <20161218135215.GA48900@kloomba> Cc: Roman Bogorodskiy , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, alexander.nusov@nfvexpress.com From: Mathieu Arnold Organization: Absolight / The FreeBSD Foundation Message-ID: Date: Sun, 18 Dec 2016 15:26:28 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161218135215.GA48900@kloomba> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fsH1SjHdFsK7riIjs2QOAoV9puFEu9H1P" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Dec 2016 14:26:33 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fsH1SjHdFsK7riIjs2QOAoV9puFEu9H1P Content-Type: multipart/mixed; boundary="rjclJLskcttRsFMWhscfhJ5ASWdEu9iqU"; protected-headers="v1" From: Mathieu Arnold To: Roman Bogorodskiy Cc: Roman Bogorodskiy , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, alexander.nusov@nfvexpress.com Message-ID: Subject: Re: svn commit: r428845 - in head/devel: . py-XStatic py-XStatic-Angular py-XStatic-Angular-Bootstrap py-XStatic-Angular-FileUpload py-XStatic-Angular-Gettext py-XStatic-Angular-Schema-Form py-XStatic-... References: <201612181136.uBIBaQLG037821@repo.freebsd.org> <56123f95-c5dc-1e3a-3db5-d87043949c45@FreeBSD.org> <20161218135215.GA48900@kloomba> In-Reply-To: <20161218135215.GA48900@kloomba> --rjclJLskcttRsFMWhscfhJ5ASWdEu9iqU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Le 18/12/2016 =C3=A0 14:52, Roman Bogorodskiy a =C3=A9crit : > Mathieu Arnold wrote: > >> Le 18/12/2016 =C3=A0 12:36, Roman Bogorodskiy a =C3=A9crit : >>> +COMMENT=3D Xstatic-angular-bootstrap >>> >>> Added: head/devel/py-XStatic-Angular-Bootstrap/pkg-descr >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- /dev/null 00:00:00 1970 (empty, because file is newly added) >>> +++ head/devel/py-XStatic-Angular-Bootstrap/pkg-descr Sun Dec 18 11:3= 6:26 2016 (r428845) >>> @@ -0,0 +1,3 @@ >>> +XStatic-Angular-Bootstrap >>> + >>> +WWW: http://pypi.python.org/pypi/XStatic-Angular-Bootstrap >>> +COMMENT=3D Angular-fileupload 12.0.4 (xstatic packaging standard) >>> >>> Added: head/devel/py-XStatic-Angular-FileUpload/pkg-descr >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D >>> --- /dev/null 00:00:00 1970 (empty, because file is newly added) >>> +++ head/devel/py-XStatic-Angular-FileUpload/pkg-descr Sun Dec 18 11:= 36:26 2016 (r428845) >>> @@ -0,0 +1,3 @@ >>> +Angular-FileUpload 12.0.4 (XStatic packaging standard) >>> + >>> +WWW: http://pypi.python.org/pypi/XStatic-Angular-FileUpload >> ... >> >> I understand those were mechanically created, but all the COMMENT[1] a= nd >> pkg-descr[2] files fall very short of our requirements. >> >> 1: >> https://www.freebsd.org/doc/en/books/porters-handbook/makefile-comment= =2Ehtml >> >> 2: https://www.freebsd.org/doc/en/books/porters-handbook/porting-desc.= html > This is generally an information obtained from the corresponding Python= > packages. E.g. for XStatic-Angular-FileUpload we only have: Let me quote one of the rules for COMMENT: 2) Do not include the package name or version number of software. The fact that python does not enforce rules on their packages does not mean we do not. > We probably can add README contents to pkg-descr (I'm not sure it bring= s > a lot of value though, it looks likes it's more or less common for thes= e > packages with only package name changed), but I'm not sure how can we > improve COMMENT. Please read the handbook links I gave you. COMMENT is a short, one line, description of the software. pkg-descr is a longer description, it should tell me what does, what it is, why it is usefull. Especially, I should not have to go to the web site to understand those things. --=20 Mathieu Arnold --rjclJLskcttRsFMWhscfhJ5ASWdEu9iqU-- --fsH1SjHdFsK7riIjs2QOAoV9puFEu9H1P Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJYVpyVXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85ImZIP/0bKI3Qy8/YECJ4kBfeolk/P L1CsYn/pUTO+yPm3QmiErw112ld6yeU0GiLNl+ZuyAOPkWWOm8VOK/81OfeC1Yvz VNequkKXHZTgPvEgiL5QlTl8ck9JAFsGx6UW+c/ahROKKmQcADD0EdfNaHcUHrnG S5fSBLK80la5htdPifCIiySa5Ob0mXOfw2bUbRX05pD0M6TWuri4KegUQGm7arQw wCh8eMqTM10aqfCRnP3TmXIKsKX5nWunvRYK50Es6adx3HvrnHE7JtGOZZO8mtpt NbPDu8mCEnUCN32Z54mDAMPCbgLad4xaXSxFWyyjaHGNdx5CTN+ieJZhgjPIYHzD ibLjXMJNP2fMrPlxLppgkiAR1pvtGk1Ggp+HKxz5ggnooawCgdCi2RTkfW5FHDsB twPDmHk+CQ0vNBLoMmuLY87RbSEP5k1NhnXIe6qARm+rZmqbFriMYw2yXKqhqMv5 iM+Gc8nS5xMykj8BLwLx1GgCUyZnZrzz07r9bvI/6pvVA+/e4x5aXeHsJgFkA6In x0Mng96+oZM21Pac52iJRhPOpKt+88FTt6w9Q6gz5TaZPPnanZqqa5rjWALkhowd c/NeAMpQR+NOPbwUnguSqzSkDizwJw4ijXf2Iq9M9OwCmcKmlJMALLimNuViYolI oHJtbI51o1AICu/ytnGP =XHmh -----END PGP SIGNATURE----- --fsH1SjHdFsK7riIjs2QOAoV9puFEu9H1P--