From nobody Sat Aug 8 00:44:14 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hH2Mf6Bx5z6mZSC for ; Sat, 08 Aug 2026 00:44:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hH2Mf4YMbz3x3L for ; Sat, 08 Aug 2026 00:44:14 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786149854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lEhlc7jHdWrBiJ3qYfr7WTmQMTsu7wCLqQKwmvmAaqE=; b=EmbJe0qGU0AIJX7tg92MCvua4hAMGbMmiXJvnrWGPbJH/f7CxEqj/3UjBAWK5KADHywx0F xKuaGEqbGQNEaf/c4RjjCQhTuzm3kEoDdPRvEljLJ2MIK47cf6a2MMB5qIwFGRmPElQ7G8 KmdMvMzXuGCTaO8tMBMKg3h2O4oqBVumP/J/raw2QT4Cp/Zoe3yrWLNt2LDuArJsHqT3XS Co2M1C+DFDXq2zOKau9aPtpJ++QfYt7Lzt+wTCdIVpF6I0dSh4hD5Z5rDpmsQj+FgMGrJD ouKW6fR+wCrVB5kX0BX7AtcNyu203FtyfINJnzsLLyOIFDai16aHU3M3uHy8Fg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1786149854; a=rsa-sha256; cv=none; b=CA9sWnL2SlLWraDkdJ/vbST/U+Ep8DTkN7efAYWHFUGvz3igCwP+fFSmtnvtCOtVLadPjA 7lc2XF+hTG8h4JJUcZ1Z/pRgySlPYXmF32S/Ys/Jq79T0ZoDirhbcNP1Jf3DsS9iQv2zpQ qTSjHrghrCU4ut4jdXqJsF+La+W6qyvCCPUcHouchmkezYFMgSKRxqa5qI3fBP++kL3P4h oNEUtonSEO47rbKtHu3p+XG/yvkO7yf0mYEZb/fEfn6h9rDsvU1K1K8Jm+367f3CC4IXpG N9scKnTTNCcXHiNH7V/bPd9BLoGPJOjXOcTVkYlyg+naHqtu0f1qa8G5azbtXw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1786149854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lEhlc7jHdWrBiJ3qYfr7WTmQMTsu7wCLqQKwmvmAaqE=; b=FM6bWkfJTdudMI8AB4MvAAzW3cTZBBRxxdYzPYn3j6bAf8l6Sglc/sUW5ChDFy0mYBWnuG PRLTdmeVEBShaETqRRxdnpTQkemJ30QyPhpYslYjUoNGNhhGpJBMQABxNeiIVLVJksLg8o ObHFitWfnH5/yurp/Dg3qSLtLb35mORTvRacOlc+x36ilg0F+kOG9rXKNx3eWbnY4vCFpB oLRgeppBzZt41n09xySDnf0OCAmT1CulmMSOJ1NF4nBney23FO8zky60gvOGWzeK5BPkxr BSxKa/gnfdg0J149Sv6Hf1PuH5tl3f2Yb7kdy4Wp29t5HfsssgzhUOA05QHsIw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hH2Mf35qTz1B2 for ; Sat, 08 Aug 2026 00:44:14 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3ec43 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 08 Aug 2026 00:44:14 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kevin Bowling Subject: git: 33fb0b470b36 - stable/14 - ixgbe: fix host interface timeout detection List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 33fb0b470b36e3b7aa0f2b8979f203f0bdee9d10 Auto-Submitted: auto-generated Date: Sat, 08 Aug 2026 00:44:14 +0000 Message-Id: <6a767bde.3ec43.7c2e3436@gitrepo.freebsd.org> The branch stable/14 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=33fb0b470b36e3b7aa0f2b8979f203f0bdee9d10 commit 33fb0b470b36e3b7aa0f2b8979f203f0bdee9d10 Author: Kevin Bowling AuthorDate: 2026-07-28 11:21:14 +0000 Commit: Kevin Bowling CommitDate: 2026-08-08 00:42:51 +0000 ixgbe: fix host interface timeout detection The host-interface polling loop was scaled from milliseconds to microseconds, but its terminal test was left using the unscaled timeout. Completion at that intermediate iteration can be reported as a timeout, while actual expiry is not recognized and can accept stale status. Test against the scaled loop bound used by the polling loop. Fixes: f46d75c90f5f ("ixgbe: improve MDIO performance by reducing semaphore/IPC delays") (cherry picked from commit db2bf4553ce32fdcae00f6e7392a6c2010247dd6) --- sys/dev/ixgbe/ixgbe_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/ixgbe/ixgbe_common.c b/sys/dev/ixgbe/ixgbe_common.c index 6495bfdecc60..439b861a17e9 100644 --- a/sys/dev/ixgbe/ixgbe_common.c +++ b/sys/dev/ixgbe/ixgbe_common.c @@ -4646,7 +4646,7 @@ s32 ixgbe_hic_unlocked(struct ixgbe_hw *hw, u32 *buffer, u32 length, return IXGBE_SUCCESS; /* Check command completion */ - if ((timeout && i == timeout) || + if ((timeout && i == timeout * 1000) || !(IXGBE_READ_REG(hw, IXGBE_HICR) & IXGBE_HICR_SV)) { ERROR_REPORT1(IXGBE_ERROR_CAUTION, "Command has failed with no status valid.\n");