From nobody Mon Apr 8 21:15:22 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VD2290ZMKz5Fptf for ; Mon, 8 Apr 2024 21:16:01 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VD22908Tmz4JlR for ; Mon, 8 Apr 2024 21:16:01 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712610961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+4KXdQA2FG/AXFFBzD2xJ+Mj4eYXcPLBNqwCvCAhbI4=; b=jZ/7shhilGBwcQ2fzJkL6vEHbNIl2BTcR9GiGJ4PD0MM4IMvv9gMW+Q9okeEKC3aULDX0/ BTNGUbymEs7/sDw2a52e99xPS76tmth20DjcGx4XdY68Au7gPLk+nB+Qe/RrJlXk73mH36 UGlJb+Y4au/i6jciSEq5TmDGPXsp7ZtkixMPrC5pe+elDnC6ksOWJ9Xu/yjILwNPL0UEHR Gri1Z5b8YJIuLDc8D7vnoEds2TQ9jjl3Jhu/+pYzSgkEiZ4Ck+g2g92hW9EHLMavtI7mnd d+5srvmkjQrVbkhigFBGpAxrJ/4pIpaWQ0ECSlj2eHs6CQHoUHc0JIWpcAzQew== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1712610961; a=rsa-sha256; cv=none; b=tLp+IJfxq/OddGBHcqCm/HfdnNPPEjSgKOebtp9eMErOr+J0oRhW9qemW7b51oHbXA+73K JTCfeA5dHzW5srbzkxVRxx5Kq/vC0DIB55bXbwbh11bXhTJZp0sb57j1XwCHw1L7St9aUA seRJriWMV7bxSydiobCq+qLAqPkppeU0fdWco04uDpMmWMY0d1jGAFAstN8Sr9ccS3jrKL To3mlJlG//UFdyoW1x6O+tWdEkujeVLBrszTt+v9PxywYi1GLz6oqNMvPMAkg/EeT4WIDm 9/4P+pjGUl4prUgYQQrOXteGqXcugVO5qMuGmklF9x1e/c872H/8N7qHGXhUAg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712610961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+4KXdQA2FG/AXFFBzD2xJ+Mj4eYXcPLBNqwCvCAhbI4=; b=Ml+Tr1clR0RW05MDMvA3TEyOmlcfW6btPHexfhr5V7P9Ad7SfrSb1Qa1eSihwjkPwpSwOr XkYMi76hGzcJ3DTDOnxw6EMxq23V5noud7fQQpPfS5LEy8qgQFtxWGcvB/TwLREKTGKYcg 2OyDtCwQnmoj4CJm3BFgmjeG7BM2rIuClH9MCXnfDZnPHLU4T1BL5yE3meu3VRNhWNjKHF lcMdzP14lflo8RepY6gPP/eJcqOsIvkc8eSlTvTzcD9eSzC2fRF/VgJCjRa3F45OMNZ9tx RavcwJQKUIR6LEcTrJS5/pXEEd47AxzF2ZU0cPfdMc2j/mCgEwo0iLPny6XeEw== Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VD2286tBRzY5S for ; Mon, 8 Apr 2024 21:16:00 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a5199906493so474615166b.1 for ; Mon, 08 Apr 2024 14:16:00 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVBNp7TvhMIFU2loZKNh5992MyUB7lVt3jt7wlGAvUb6Acyemp6H3Vz05+usZYh4D63N69UnQVuQRZXLtVaBEvilSXqNw559Sk++2OQNWtgq890 X-Gm-Message-State: AOJu0YxPu0tElSTNjslRH1alAxi8s4xLMguwZkd2+PgAdLRTN8A0dTfH EWV+AiD3J16eD49q0J5nkO2NA2JALlvC/6SXBvXwhVpIOjGDM0frw7RQAd46z6bV6w2btuiUbgA ZSDMrDKt5V/dhW5QKeP6Lr40S/HD+HfNsb8G8xQ== X-Google-Smtp-Source: AGHT+IHtYlPeCzScWxifThUzJxE4L+KSwnx8LM8VSmSiEhBYEFT1Shf1gHPN4eqcbDw2JV5tUK5M0KU2Zipjlp1TdIA= X-Received: by 2002:a17:906:f754:b0:a4e:a272:d57f with SMTP id jp20-20020a170906f75400b00a4ea272d57fmr6130236ejb.46.1712610959548; Mon, 08 Apr 2024 14:15:59 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202403231747.42NHlaRh091094@gitrepo.freebsd.org> In-Reply-To: <202403231747.42NHlaRh091094@gitrepo.freebsd.org> From: Po-Chuan Hsieh Date: Tue, 9 Apr 2024 05:15:22 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: cc9c37d73947 - main - */*: Always use WRK_ENV with SETENVI To: Tijl Coosemans Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000e2089706159c4f6c" --000000000000e2089706159c4f6c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Tijl, On Sun, Mar 24, 2024 at 1:47=E2=80=AFAM Tijl Coosemans w= rote: > The branch main has been updated by tijl: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3Dcc9c37d73947e0184f66f0b5fa3fc= 021f7fdf51c > > commit cc9c37d73947e0184f66f0b5fa3fc021f7fdf51c > Author: Tijl Coosemans > AuthorDate: 2024-03-23 17:35:13 +0000 > Commit: Tijl Coosemans > CommitDate: 2024-03-23 17:45:45 +0000 > > */*: Always use WRK_ENV with SETENVI > > WRK_ENV contains environment variables like OSVERSION and UNAME_* tha= t > are needed when cross-building packages using Poudriere for a differe= nt > version of FreeBSD or a different architecture than that of the host > system. It's just my 2 cents. If SETENVI and WRK_ENV always come together, it would be better to have a new knob for it (e.g. SET_BASIC_ENV, SET_COMMON_ENV or SET_MIN_ENV). Therefore we won't use only part of them. The side benefit is it's shorter. Since WRK_ENV contains a minimal set of common environment variables, could we rename it to a more intuitive name such as COMMON_ENV or something like that? Regards, sunpoet --000000000000e2089706159c4f6c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Tijl,

On Sun, Mar 24, 2024 at 1:47=E2=80=AFAM Ti= jl Coosemans <tijl= @freebsd.org> wrote:
The branch main has been updated by tijl:

URL: https://cgi= t.FreeBSD.org/ports/commit/?id=3Dcc9c37d73947e0184f66f0b5fa3fc021f7fdf51c

commit cc9c37d73947e0184f66f0b5fa3fc021f7fdf51c
Author:=C2=A0 =C2=A0 =C2=A0Tijl Coosemans <tijl@FreeBSD.org>
AuthorDate: 2024-03-23 17:35:13 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Tijl Coosemans <tijl@FreeBSD.org>
CommitDate: 2024-03-23 17:45:45 +0000

=C2=A0 =C2=A0 */*: Always use WRK_ENV with SETENVI

=C2=A0 =C2=A0 WRK_ENV contains environment variables like OSVERSION and UNA= ME_* that
=C2=A0 =C2=A0 are needed when cross-building packages using Poudriere for a= different
=C2=A0 =C2=A0 version of FreeBSD or a different architecture than that of t= he host
=C2=A0 =C2=A0 system.




<= /div> --000000000000e2089706159c4f6c--