From nobody Wed Oct 1 18:35:50 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ccNsj6PSkz6989L; Wed, 01 Oct 2025 18:35:53 +0000 (UTC) (envelope-from garga@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ccNsj5P47z3lwP; Wed, 01 Oct 2025 18:35:53 +0000 (UTC) (envelope-from garga@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759343753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=WBmr/s79lNR0i0k/7Ws/Z0ov+DIJhUen6T5MhlqIjaU=; b=U/l5VAzPKeiaahhTBLBbacLxllyFRL1OLOVjiLgVa/mzbtnkrFdgntN+H7G8XmXlPQ7yyz 6AXsK3ekh6p/7K8rg12M7k6VnVr9AMGpILoEr6LozXra72YRuxGSe/Gd0ZCD7iwfeZRADI XGvNCX4pl3tl+0VQTwJXCxvrIJ/jCzlDkg1ipipQzx6oZUIbz/75D2qluhN3w0xtneEY9S vU0ln5/p/XN57SOz5PQjS3xf6TzT6t6C/DUwu5efE1ouktRZC14p/L2USbZ3iagDtBmUxk djly0vPg53BskrGYWuY06TGHaU0RznBlMJKqQuO6b88WeK3qYkjdGiao0OVM5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759343753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=WBmr/s79lNR0i0k/7Ws/Z0ov+DIJhUen6T5MhlqIjaU=; b=budiB7//KIz7zX6NJ8tJisQFHog2Q+U3pctMXj0CbAgh68HDNBNYsWev14cV2k+Xne4KE4 NnMuCfX5pd1RZOqMLJV6gJ2dmTrWcGQtEdm7yqRtpQnWJPy9hYdV6lCHAH31vzdNC5YSb5 QrveRS7wpE4mczTCWOwSgOsf6rbwZ/KvUgWvSdjph1AKYxc56Ex2njaKE3KwtvkucGOO3v TcYfQJDcvj261F60ShS0WGdZDX/ux2t5WUtWNqhZGaeKL7BLTPTq+yfPsCNkaTWCdPc56v xu73RLsdH+1CjSgIO6tgZTa/Vxd4dYtZGOxAnVGw4/7sqpwyaUZQv0UpRr6f6Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759343753; a=rsa-sha256; cv=none; b=EVHh3Xn/yP4NEqvLruODGQavVjBX31XKKG60EC087sFGtsOV3w8+81tLmnzYqDa7Pqmpe8 NVKueUC6B3R354KBlFCnMd/G09nb8bApKsAi20XAEXp7svsK05jP96jxKg/di4R8ycAcP4 aE8H3PHFqV/e1wOO3RmNlZxwjYwCaIm75I6cfsPMfyt0H2tpjyhi42IRmKJVhj3A+z5bJf 1b4tOKCj0Fh8qNehR0ickrxg/kJOtIDdIdyBXU57fVnwi3L0YFVvCfbVREKRJxHHUYBo2N kcS1Q5uHo3UVIXeoB8OwYjhc9/7MJWNFQRT1IzTqt8vxkwjQwNr8ILZw5VMVig== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2804:f1c:3e:b01:b0aa:d62b:23d6:ca2] (unknown [IPv6:2804:f1c:3e:b01:b0aa:d62b:23d6:ca2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: garga) by smtp.freebsd.org (Postfix) with ESMTPSA id 4ccNsj0Fw7zJKq; Wed, 01 Oct 2025 18:35:52 +0000 (UTC) (envelope-from garga@FreeBSD.org) Message-ID: <85c486e1-6fde-4f4a-b4ce-bfbec7bb693f@FreeBSD.org> Date: Wed, 1 Oct 2025 15:35:50 -0300 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 08f06aa1b4fb - main - vfs: retire the VCALL macro To: Mateusz Guzik , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202509270401.58R41A7b014829__21824.1523530864$1758945716$gmane$org@gitrepo.freebsd.org> Content-Language: en-US From: Renato Botelho Autocrypt: addr=garga@FreeBSD.org; keydata= xsBNBGStavwBCACjNlp/9+Y+VFe9ieR2h/WWbdvjz4Mb2z/f22bGoaskzCfvVNbo/v3i34I9 H6OdgZkGqheQEAD2jNfRbmPr4z40xDMUpYGLds+1Mvg7G3Hms3j5Ef8KaLSWUNWIfwKdfSVR Qs35ccSJxAdRW5YdI6J3xZgika+3Bc4eJ05YE/nWW+PNTYevt5rqD50N3zybVYIcLoqVPpBi AZE/sf5SLiLACIJb1t/s4x+pi8vgWevxVVT9u8V1f8zYErmHSLSqjxii0B3eRZphX9NCJOv9 +tfFZhnENInhn9gT7H4e2YumUltEy3jacONHJF3CC1pvvWEa6lEyypclMOkHQwNON7DLABEB AAHNLFJlbmF0byBCb3RlbGhvIChGcmVlQlNEKSA8Z2FyZ2FARnJlZUJTRC5vcmc+wsCXBBMB CgBBAhsDBQkFo5qABQsJCAcDBRUKCQgLBRYDAgEAAh4FAheAFiEERL7Dxegbnh7xTiQ5Ob6P xxJcZXoFAmSta78CGQEACgkQOb6PxxJcZXrYlggAgaZmr6c1yIWzN8VksHrHpwt/uxONEP+h ljy3yfrMsgfS5wx5Uzgfih1xYZUFC6jiI63CetqBqJpp3g1klRS1UWYKx2NeXphDMYZEdPm/ a6sXh4bKZbk6IE8Yn0/YiRT57d9DtbvswC7Gn7Igj/MSbhl49TvTGyvuB6juaffVoYZViomx 5zMoee8Ml2o2qj3MrCJ+/K8GU54RlpOGqGRsqdwVdr9XEWub6fF2YFwR46cjmbiU3P5urFHH nkJlBGPIwKxHimTW0lZsdx9aCKRDd/D80/WOEzXmk3k8B9lv/GsvOluHmveLhJG1R1tIJ31I f2q8dfTvqsQXnu8CcWRcgc7ATQRkrWr8AQgA1DufoxScA+CWQbUR6zExIu8wXQKrhuRt4DG2 BgynT7EMUvEBadcbQRZXsBpemNfncc9Axyut/+rWiyKJf9BLQuo/9QYmSRvW1U6+0LJUYmdg kMyBeYaPk+vnssv/u9jLuvV7FVgyE0yk1iaWIKOVDD+XrQCOvGw9uSceBrQyCyo3A/eRM/+p vnDCaywR63PKE+3axk6lfNdGK3TnaWmS30/ZDCZlNsXuqprqR4JdT5wXids5o36dsuJ5EZ20 s5hNMD34s4Yr1Y1R9elH6qBsFCpozs0+jwrArxq+UJJCR6hH5W8ZEwJtRC8tzR8mRE1WywzX BXYj0YhfGztQIxZckQARAQABwsB8BBgBCgAmFiEERL7Dxegbnh7xTiQ5Ob6PxxJcZXoFAmSt avwCGwwFCQWjmoAACgkQOb6PxxJcZXr1vgf/SKXhoZcUU5I7TqcbHg0lJz9tICTupCGHWr/s SQgjh9oEM5j1wqW7FlCGP90Tl9K0g3ow9YdbhU7VK470o6pymX9V9eLHzGgkZO/KMEtGBeK1 u+5ePjCJ/MK5B21KODLSU7WrIL1VN5ceXfQPLYt02LMLtPri+oduHD6RNBeA7US1DUzleq5F 9NHGbvV2U7BdDUezpiO8NaFjFZVB11I5d99FxUM5XGVstI3VhsRKZxjY0KnqJzaQgTFsPGmv AUfZVIN1pXgXiedhPXpr8+Y64jP+pHVwpVmh1zYWL6+q3kqFOUVP6c5iiMeoEXZvgJz7x/AC ek3X5gvu8Hpcv+MZIg== In-Reply-To: <202509270401.58R41A7b014829__21824.1523530864$1758945716$gmane$org@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 27/09/25 01:01, Mateusz Guzik wrote: > The branch main has been updated by mjg: > > URL: https://cgit.FreeBSD.org/src/commit/?id=08f06aa1b4fb6db0d8beb3e1c328b1c1adbec13a > > commit 08f06aa1b4fb6db0d8beb3e1c328b1c1adbec13a > Author: Mateusz Guzik > AuthorDate: 2025-09-27 02:01:32 +0000 > Commit: Mateusz Guzik > CommitDate: 2025-09-27 04:00:59 +0000 > > vfs: retire the VCALL macro > > There is precisely one place using it and even that should probably go > away. > --- > sys/fs/nullfs/null_vnops.c | 2 +- > sys/sys/vnode.h | 5 ----- > 2 files changed, 1 insertion(+), 6 deletions(-) > > diff --git a/sys/fs/nullfs/null_vnops.c b/sys/fs/nullfs/null_vnops.c > index 74c1a8f3acb6..ba29b0485326 100644 > --- a/sys/fs/nullfs/null_vnops.c > +++ b/sys/fs/nullfs/null_vnops.c > @@ -306,7 +306,7 @@ null_bypass(struct vop_generic_args *ap) > * with the modified argument structure. > */ > if (vps_p[0] != NULL && *vps_p[0] != NULL) { > - error = VCALL(ap); > + error = ap->a_desc->vdesc_call(ap); > } else { > printf("null_bypass: no map for %s\n", descp->vdesc_name); > error = EINVAL; > diff --git a/sys/sys/vnode.h b/sys/sys/vnode.h > index 6ef9bbec9446..fcfb8716fc52 100644 > --- a/sys/sys/vnode.h > +++ b/sys/sys/vnode.h > @@ -594,11 +594,6 @@ void assert_vop_unlocked(struct vnode *vp, const char *str); > > #endif /* INVARIANTS */ > > -/* > - * This call works for vnodes in the kernel. > - */ > -#define VCALL(c) ((c)->a_desc->vdesc_call(c)) > - > #define DOINGASYNC(vp) \ > (((vp)->v_mount->mnt_kern_flag & MNTK_ASYNC) != 0 && \ > ((curthread->td_pflags & TDP_SYNCIO) == 0)) > > FYI, this commit along with retirement of NULLVP and VREF broke open-vm-kmod build on current. I wonder if there are move ports that could be affected. -- Renato Botelho