From owner-svn-src-head@FreeBSD.ORG Sun Sep 22 12:33:30 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 922C9D8; Sun, 22 Sep 2013 12:33:30 +0000 (UTC) (envelope-from gibbs@freebsd.org) Received: from aslan.scsiguy.com (www.scsiguy.com [70.89.174.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 674E02CB0; Sun, 22 Sep 2013 12:33:30 +0000 (UTC) Received: from macbook.scsiguy.com (macbook.scsiguy.com [192.168.0.99]) (authenticated bits=0) by aslan.scsiguy.com (8.14.7/8.14.5) with ESMTP id r8MCXSTf071390 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Sun, 22 Sep 2013 06:33:29 -0600 (MDT) (envelope-from gibbs@freebsd.org) Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\)) Subject: Re: svn commit: r255783 - head/sys/kern From: "Justin T. Gibbs" In-Reply-To: Date: Sun, 22 Sep 2013 06:33:29 -0600 Message-Id: References: <201309220246.r8M2kEIN054172@svn.freebsd.org> To: Aryeh Friedman X-Mailer: Apple Mail (2.1510) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (aslan.scsiguy.com [70.89.174.89]); Sun, 22 Sep 2013 06:33:29 -0600 (MDT) Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Sep 2013 12:33:30 -0000 On Sep 22, 2013, at 12:38 AM, Aryeh Friedman = wrote: > On Sat, Sep 21, 2013 at 10:46 PM, Justin T. Gibbs = wrote: > Author: gibbs > Date: Sun Sep 22 02:46:13 2013 > New Revision: 255783 > URL: http://svnweb.freebsd.org/changeset/base/255783 >=20 > Log: > Fix ia64 and mips kernel builds due to XENHVM=3D>GENERIC integration = in > revision 255744. >=20 > sys/kern/subr_smp.c: > IPI_SUSPEND is only available on amd64 and i386. Protect > new uses of this constant with #ifdefs to avoid impacting > other platforms. >=20 > Approved by: re (blanket Xen) >=20 > Modified: > head/sys/kern/subr_smp.c >=20 > Modified: head/sys/kern/subr_smp.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/kern/subr_smp.c Sun Sep 22 02:14:54 2013 = (r255782) > +++ head/sys/kern/subr_smp.c Sun Sep 22 02:46:13 2013 = (r255783) > @@ -225,6 +225,7 @@ generic_stop_cpus(cpuset_t map, u_int ty > CTR2(KTR_SMP, "stop_cpus(%s) with %u type", > cpusetobj_strprint(cpusetbuf, &map), type); >=20 > +#if defined(__amd64__) || defined(__i386__) > /* > * When suspending, ensure there are are no IPIs in progress. > * IPIs that have been issued, but not yet delivered (e.g. > @@ -234,6 +235,7 @@ generic_stop_cpus(cpuset_t map, u_int ty > */ > if (type =3D=3D IPI_SUSPEND) > mtx_lock_spin(&smp_ipi_mtx); > +#endif >=20 > if (stopping_cpu !=3D PCPU_GET(cpuid)) > while (atomic_cmpset_int(&stopping_cpu, NOCPU, > @@ -262,8 +264,10 @@ generic_stop_cpus(cpuset_t map, u_int ty > } > } >=20 > +#if defined(__amd64__) || defined(__i386__) > if (type =3D=3D IPI_SUSPEND) > mtx_unlock_spin(&smp_ipi_mtx); > +#endif >=20 > stopping_cpu =3D NOCPU; > return (1); > _______________________________________________ > svn-src-all@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" >=20 >=20 > This seems to cause a kernel panic if the machine is left idle for too = long Seeing the actual panic text would help me to address the issue. -- Justin=