From owner-svn-src-all@FreeBSD.ORG Fri Aug 29 17:30:38 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0BB6783B; Fri, 29 Aug 2014 17:30:38 +0000 (UTC) Received: from mail-wg0-x22f.google.com (mail-wg0-x22f.google.com [IPv6:2a00:1450:400c:c00::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 08EE01B6F; Fri, 29 Aug 2014 17:30:36 +0000 (UTC) Received: by mail-wg0-f47.google.com with SMTP id z12so2481953wgg.30 for ; Fri, 29 Aug 2014 10:30:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=n10HTL3h9l1EIaX6+wvpPjOYM9n+OcYb0Um1r5RPw2Q=; b=IEAK0xAQZjbTk0TZ44wAUR/mmhLD30zKsouWkjDX7/7if6/B/PjgxSWCsRNG3ESIUt WA8Jr+9yFUTdkfMQLN2Ki245c546/9J/rVuSQZ0bBIzdsPw1RZczBFCon+uaWl9vW41J Kfp9NeErWjREh1JcTSF2MquEAgkp0VhoF3/3CzRwgDED9EiJQOs9kPv+8gd2J2DCkdnz exJCIAH/GZlDMBi86yO7iwkCnmQxMc/P+d4ADNX8B7P7goUBQ9pxKWWcNa1I27hX0VwE Yqt/Y6vQUyPC2tAxJd8D5uUYqDUC+4ozUcFwdvvL/JWTNh2z7Eh1+q97DzicJkmLGCcw rQxA== X-Received: by 10.194.108.41 with SMTP id hh9mr14800822wjb.68.1409333435176; Fri, 29 Aug 2014 10:30:35 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by mx.google.com with ESMTPSA id pn5sm1473297wjc.4.2014.08.29.10.30.33 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 29 Aug 2014 10:30:34 -0700 (PDT) Date: Fri, 29 Aug 2014 19:30:31 +0200 From: Mateusz Guzik To: John Baldwin Subject: Re: svn commit: r270745 - in head: bin/ps sys/compat/freebsd32 sys/kern sys/sys Message-ID: <20140829173031.GA21347@dft-labs.eu> References: <201408280841.s7S8fC6X012986@svn.freebsd.org> <4953508.c8Quuai1Ky@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4953508.c8Quuai1Ky@ralph.baldwin.cx> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Mateusz Guzik X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Aug 2014 17:30:38 -0000 On Fri, Aug 29, 2014 at 01:17:45PM -0400, John Baldwin wrote: > On Thursday, August 28, 2014 08:41:12 AM Mateusz Guzik wrote: > > Author: mjg > > Date: Thu Aug 28 08:41:11 2014 > > New Revision: 270745 > > URL: http://svnweb.freebsd.org/changeset/base/270745 > > > > Log: > > Return real parent pid in kinfo (used by e.g. ps) > > > > Add a separate field which exports tracer pid and add a new keyword > > ("tracer") for ps to display it. > > > > This is a follow up to r270444. > > Note that proctree_lock is now needed in several more places such as dtrace > (which uses fill_kinfo_proc()) and the ELF coredump code > (elf(N)_note_procstat_proc() calls kern_proc_out()). Weird, I was sure I checked all callers. Indeed missed them, will fix that up later. Maybe we should reconsider an incomplete approach with storing the pointer, which would require only proc lock (i.e. what was required prior to any changes) The hack I had was: https://people.freebsd.org/~mjg/patches/ptrace-hack.diff -- Mateusz Guzik