From owner-svn-src-all@freebsd.org Fri Jan 10 09:50:45 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 09BD51E2264; Fri, 10 Jan 2020 09:50:45 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from hz.grosbein.net (hz.grosbein.net [IPv6:2a01:4f8:c2c:26d8::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 47vJBq5XXmz4Q7F; Fri, 10 Jan 2020 09:50:43 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from eg.sd.rdtc.ru (eg.sd.rdtc.ru [IPv6:2a03:3100:c:13:0:0:0:5]) by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id 00A9oVXv019251 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Jan 2020 09:50:35 GMT (envelope-from eugen@grosbein.net) X-Envelope-From: eugen@grosbein.net X-Envelope-To: bapt@FreeBSD.org Received: from [10.58.0.4] (dadv@[10.58.0.4]) by eg.sd.rdtc.ru (8.15.2/8.15.2) with ESMTPS id 00A9oOGq005792 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 10 Jan 2020 16:50:24 +0700 (+07) (envelope-from eugen@grosbein.net) Subject: Re: svn commit: r356566 - stable/11/contrib/smbfs/lib/smb To: Baptiste Daroussin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org References: <202001091958.009Jw56r037444@repo.freebsd.org> From: Eugene Grosbein Message-ID: <02858bb2-f5aa-bca3-bfea-60f91465e733@grosbein.net> Date: Fri, 10 Jan 2020 16:50:24 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <202001091958.009Jw56r037444@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.3 required=5.0 tests=BAYES_00,LOCAL_FROM, SPF_HELO_NONE,SPF_PASS,T_DATE_IN_FUTURE_Q_PLUS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Report: * -2.3 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record * 0.0 T_DATE_IN_FUTURE_Q_PLUS Date: is over 4 months after Received: * date * -0.0 SPF_PASS SPF: sender matches SPF record * 2.6 LOCAL_FROM From my domains X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on hz.grosbein.net X-Rspamd-Queue-Id: 47vJBq5XXmz4Q7F X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=permerror (mx1.freebsd.org: domain of eugen@grosbein.net uses mechanism not recognized by this client) smtp.mailfrom=eugen@grosbein.net X-Spamd-Result: default: False [-3.85 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[grosbein.net]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-1.75)[ip: (-4.78), ipnet: 2a01:4f8::/29(-2.45), asn: 24940(-1.50), country: DE(-0.02)]; R_SPF_PERMFAIL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jan 2020 09:50:45 -0000 10.01.2020 2:58, Baptiste Daroussin wrote: > Author: bapt > Date: Thu Jan 9 19:58:05 2020 > New Revision: 356566 > URL: https://svnweb.freebsd.org/changeset/base/356566 > > Log: > MFC r356317 (by arrowd): > > mount_smbfs: Issue a warning when .nsmbrc section name contains lowercase characters. > > PR: 231656 > Approved by: bapt > Differential Revision: https://reviews.freebsd.org/D22289 > > Modified: > stable/11/contrib/smbfs/lib/smb/rcfile.c > Directory Properties: > stable/11/ (props changed) > > Modified: stable/11/contrib/smbfs/lib/smb/rcfile.c > ============================================================================== > --- stable/11/contrib/smbfs/lib/smb/rcfile.c Thu Jan 9 19:56:25 2020 (r356565) > +++ stable/11/contrib/smbfs/lib/smb/rcfile.c Thu Jan 9 19:58:05 2020 (r356566) > @@ -156,11 +156,19 @@ static struct rcsection * > rc_addsect(struct rcfile *rcp, const char *sectname) > { > struct rcsection *p; > + const char* sectletter = sectname; > > p = rc_findsect(rcp, sectname); > if (p) return p; > p = malloc(sizeof(*p)); > if (!p) return NULL; > + for(sectletter = sectname; *sectletter; sectletter++) { > + if (islower(*sectletter)) { > + if (strcmp(sectname, "default")) > + dprintf(STDERR_FILENO, "warning: section name [%s] contains lower-case letters\n", sectname); > + break; > + } > + } > p->rs_name = strdup(sectname); > SLIST_INIT(&p->rs_keys); > SLIST_INSERT_HEAD(&rcp->rf_sect, p, rs_next); This commit broke source upgrade path from 10.4-STABLE to stable/11: rcfile.c:168:5: error: implicit declaration of function 'dprintf' is invalid in C99 [-Werror,-Wimplicit-function-declaration] dprintf(STDERR_FILENO, "warning: section name [%s] contains lower-case letters\n", sectname); ^ 1 error generated.