From owner-cvs-all Tue Mar 7 15:20:11 2000 Delivered-To: cvs-all@freebsd.org Received: from awfulhak.org (tun.AwfulHak.org [194.242.139.173]) by hub.freebsd.org (Postfix) with ESMTP id 533D937B598; Tue, 7 Mar 2000 15:17:45 -0800 (PST) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (root@hak.lan.awfulhak.org [172.16.0.12]) by awfulhak.org (8.9.3/8.9.3) with ESMTP id XAA00934; Tue, 7 Mar 2000 23:16:17 GMT (envelope-from brian@hak.lan.Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.9.3/8.9.3) with ESMTP id XAA04073; Tue, 7 Mar 2000 23:16:14 GMT (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200003072316.XAA04073@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.1.1 10/15/1999 To: Sheldon Hearn Cc: Brian Somers , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@hak.lan.awfulhak.org, brian@hak.lan.awfulhak.org Subject: Re: cvs commit: src/share/man/man4 tun.4 In-Reply-To: Message from Sheldon Hearn of "Tue, 07 Mar 2000 14:37:58 +0200." <93506.952432678@axl.ops.uunet.co.za> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 07 Mar 2000 23:16:14 +0000 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > On Mon, 06 Mar 2000 23:09:53 GMT, Brian Somers wrote: > > > Yes - with the TUNSIFMODE ioctl. This is different from how OpenBSD > > does it (where our struct tuninfo has a ``dummy'' field, OpenBSDs has > > a ``flags'' field where you put IFF_* bits). > > So then the following patch from NetBSD makes sense, yes? No, not at the moment. IFF_POINTOPOINT and IFF_BROADCAST are opposites, so TUNSIFMODE can be used to undo what it's already done. In FreeBSD, IFF_MULTICAST is always there. In NetBSD there's SIOCADDMULTI and SIOCDELMULTI and in OpenBSD there's struct tuninfo's flags field (passed to TUNSIFINFO). I'd condone supporting SIOCADDMULTI and SIOCDELMULTI, and also having a flags field in struct tuninfo, but I don't know if this is a good idea on a more general level.... ie, should there really be two ways to do these things ? For the moment though, I think the documentation is right. > Index: tun.4 > =================================================================== > RCS file: /home/ncvs/src/share/man/man4/tun.4,v > retrieving revision 1.9 > diff -u -d -r1.9 tun.4 > --- tun.4 2000/03/06 07:08:14 1.9 > +++ tun.4 2000/03/07 12:37:25 > @@ -147,7 +147,10 @@ > its value must be either > .Dv IFF_POINTOPOINT > or > -.Dv IFF_BROADCAST . > +.Dv IFF_BROADCAST > +(optionally > +.Dv IFF_MULTICAST > +may be or'ed into the value). > The type of the corresponding > .Em tun Ns Sy n > interface is set to the supplied type. If the value is anything else, > > Ciao, > Sheldon. > -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message