Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 14 Jul 2014 14:33:03 +0000 (UTC)
From:      Steven Hartland <smh@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r268621 - head/cddl/contrib/opensolaris/cmd/zpool
Message-ID:  <201407141433.s6EEX3rp002481@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: smh
Date: Mon Jul 14 14:33:03 2014
New Revision: 268621
URL: http://svnweb.freebsd.org/changeset/base/268621

Log:
  Don't report non-native block-size pools under zpool status -x
  
  zpool status -x is used to identify pools that are exhibiting
  errors or are otherwise unavailable, therefore non-native
  block-size pools shouldn't be reported.
  
  Also update man page to clarify other additional conditions
  which won't cause a pool to be displayed under zpool status -x.
  
  Sponsored by:	Multiplay

Modified:
  head/cddl/contrib/opensolaris/cmd/zpool/zpool.8
  head/cddl/contrib/opensolaris/cmd/zpool/zpool_main.c

Modified: head/cddl/contrib/opensolaris/cmd/zpool/zpool.8
==============================================================================
--- head/cddl/contrib/opensolaris/cmd/zpool/zpool.8	Mon Jul 14 13:53:10 2014	(r268620)
+++ head/cddl/contrib/opensolaris/cmd/zpool/zpool.8	Mon Jul 14 14:33:03 2014	(r268621)
@@ -1664,7 +1664,8 @@ can change.
 .It Fl x
 Only display status for pools that are exhibiting errors or are otherwise
 unavailable.
-Warnings about pools not using the latest on-disk format will not be included.
+Warnings about pools not using the latest on-disk format, having non-native
+block size or disabled features will not be included.
 .It Fl v
 Displays verbose data error information, printing out a complete list of all
 data errors since the last complete pool scrub.

Modified: head/cddl/contrib/opensolaris/cmd/zpool/zpool_main.c
==============================================================================
--- head/cddl/contrib/opensolaris/cmd/zpool/zpool_main.c	Mon Jul 14 13:53:10 2014	(r268620)
+++ head/cddl/contrib/opensolaris/cmd/zpool/zpool_main.c	Mon Jul 14 14:33:03 2014	(r268621)
@@ -4101,6 +4101,7 @@ status_callback(zpool_handle_t *zhp, voi
 	if (cbp->cb_explain &&
 	    (reason == ZPOOL_STATUS_OK ||
 	    reason == ZPOOL_STATUS_VERSION_OLDER ||
+	    reason == ZPOOL_STATUS_NON_NATIVE_ASHIFT ||
 	    reason == ZPOOL_STATUS_FEAT_DISABLED)) {
 		if (!cbp->cb_allpools) {
 			(void) printf(gettext("pool '%s' is healthy\n"),



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201407141433.s6EEX3rp002481>