From owner-freebsd-bugs  Tue Nov  2 11: 0: 5 1999
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id EEF9414F10
	for <freebsd-bugs@FreeBSD.org>; Tue,  2 Nov 1999 11:00:01 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id LAA90889;
	Tue, 2 Nov 1999 11:00:01 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from thoth.mch.sni.de (thoth.mch.sni.de [192.35.17.2])
	by hub.freebsd.org (Postfix) with ESMTP id 613D514CE8
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  2 Nov 1999 10:49:57 -0800 (PST)
	(envelope-from andre.albsmeier@mchp.siemens.de)
Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11])
	by thoth.mch.sni.de (8.9.3/8.9.3) with ESMTP id TAA26879
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 2 Nov 1999 19:49:55 +0100 (MET)
Received: from curry.mchp.siemens.de (curry.mchp.siemens.de [139.25.42.7])
	by mail2.siemens.de (8.9.3/8.9.3) with ESMTP id TAA06838
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 2 Nov 1999 19:49:55 +0100 (MET)
Received: (from daemon@localhost)
	by curry.mchp.siemens.de (8.9.3/8.9.3) id TAA28329
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 2 Nov 1999 19:49:54 +0100 (CET)
Message-Id: <199911021849.TAA28716@internal>
Date: Tue, 2 Nov 1999 19:49:53 +0100 (CET)
From: Andre Albsmeier <andre.albsmeier@mchp.siemens.de>
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: gnu/14664: tar checks for volno-file even if it shouldn't
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         14664
>Category:       gnu
>Synopsis:       tar checks for volno-file even if it shouldn't
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Nov  2 11:00:01 PST 1999
>Closed-Date:
>Last-Modified:
>Originator:     Andre Albsmeier
>Release:        FreeBSD 3.3-STABLE i386
>Organization:
>Environment:

Probably all FreeBSD versions, patch ist for -STABLE

>Description:

When using tar with the -F option but without --volno-file, the following
output appears after the first volume is full:

root@server:/dump>tar -c -F /dump/volchange -L 10 -f try.tar usr
tar: (null) : Bad address

This is because the code to modify the volno-file is called even if
there hasn't been one specified.


>How-To-Repeat:

See above.


>Fix:

The fix does the same thing as being done elsewhere when volno-file is
accessed: Do it only if the user specified --volno-file.
	
--- gnu/usr.bin/tar/buffer.c.ORI	Tue Nov  2 19:37:05 1999
+++ gnu/usr.bin/tar/buffer.c	Tue Nov  2 19:41:07 1999
@@ -1434,7 +1434,8 @@
       /* We have to prompt from now on. */
       if (f_run_script_at_end)
 	{
-	  closeout_volume_number ();
+	  if (f_volno_file)
+	    closeout_volume_number ();
 	  system (info_script);
 	}
       else

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message