Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 6 Jul 2018 18:57:45 +0200
From:      =?UTF-8?B?VMSzbA==?= Coosemans <tijl@FreeBSD.org>
To:        Jan Beich <jbeich@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r465789 - in head/devel/boost-jam: . files
Message-ID:  <20180706185745.4a2ff810@kalimero.tijl.coosemans.org>
In-Reply-To: <h8lc-s8nn-wny@FreeBSD.org>
References:  <201803280937.w2S9bdgD049991@repo.freebsd.org> <h8lc-s8nn-wny@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 06 Jul 2018 17:09:32 +0200 Jan Beich <jbeich@FreeBSD.org> wrote:
> Tijl Coosemans <tijl@FreeBSD.org> writes:
>> Author: tijl
>> Date: Wed Mar 28 09:37:38 2018
>> New Revision: 465789
>> URL: https://svnweb.freebsd.org/changeset/ports/465789
>>
>> Log:
>>   - Add a patch to make bjam call poll with timeout -1 instead of 0 so it
>>     doesn't use so much CPU time.  This cuts the build time of boost-libs
>>     in half for non-parallel builds.  
> 
> Should the fix be dropped on Boost 1.68 update? If not, please, update
> the rationale and/or submit upstream.
> 
> https://github.com/boostorg/build/commit/8b2054417c1774e336e599004c26cbe6b207736e

After that commit you can probably drop the patch.

>> -ALL_TARGET=	cc
>> +ALL_TARGET=	cc ${WITH_DEBUG:D--debug}  
> 
> - Not consistent with DEBUG in boost-libs where it's a regular option

I think WITH_DEBUG is what every port should support, not DEBUG options.
This is something that applies to every port and we're not going to add
options to every port.

> - Flags should be passed via MAKE_ARGS, see boost-all/compiled.mk

MAKE_ARGS appears before ALL_TARGET on the command line and --debug has
to appear after if I remember correctly.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180706185745.4a2ff810>