From owner-freebsd-net@FreeBSD.ORG  Tue Apr  2 22:54:03 2013
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id BBD58F77;
 Tue,  2 Apr 2013 22:54:03 +0000 (UTC)
 (envelope-from ncrogers@gmail.com)
Received: from mail-vb0-x22d.google.com (mail-vb0-x22d.google.com
 [IPv6:2607:f8b0:400c:c02::22d])
 by mx1.freebsd.org (Postfix) with ESMTP id 67E431A3;
 Tue,  2 Apr 2013 22:54:03 +0000 (UTC)
Received: by mail-vb0-f45.google.com with SMTP id w15so9784vbf.32
 for <multiple recipients>; Tue, 02 Apr 2013 15:54:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:x-received:in-reply-to:references:date:message-id
 :subject:from:to:cc:content-type;
 bh=hWQj+2hcBLhjiOtJ7Kgh0lvd8oGfNE5bKeM5WgYWPiw=;
 b=zeCcPS+jnjuqZjTWyWB0aJTdGa4U6oAk3RrkksQ+msSV8XiKlTQWgc8Jycpgi65iJP
 qS9KV1Q5RX5WbGzJZC02O8MfwKJiff9jITo0scpRkv3wIHY7wVEQ5k+Lg3j1wFEw9+VN
 M60BUkd51ujC5EZPJ3aO/Lyi0a9I2fNvSJIO8gNgmnbTq2BV14W6z8UyDrtdhfQ6erZy
 ZM1W7mlHnshbaiA8bzM9oggTxZFXjvfzUylsbG7SuVTgzfRP9goWm2AlRxtli06/Ut6T
 KQWHhALong5EaOBmuXSIt95e3ZGSijKldd/DOrvIfrHo17P2rwQzxmP8XfpTcGzJRKu3
 BQ7A==
MIME-Version: 1.0
X-Received: by 10.52.177.163 with SMTP id cr3mr12166804vdc.94.1364943242923;
 Tue, 02 Apr 2013 15:54:02 -0700 (PDT)
Received: by 10.52.176.131 with HTTP; Tue, 2 Apr 2013 15:54:02 -0700 (PDT)
In-Reply-To: <CAJ-VmokAMn_gHqEWbywWEkqa0MZrjgEZCbrx1yn0b=X9A84CzQ@mail.gmail.com>
References: <1355177348.71087.YahooMailClassic@web121601.mail.ne1.yahoo.com>
 <50C6656E.3020601@gmail.com>
 <CAFOYbc=79HwkHm6PAyRba+ue_7Xq0dUJvLk48RwqUN0Oz6+VFw@mail.gmail.com>
 <20121211075853.GU48639@FreeBSD.org>
 <CAFOYbc=Yh3WiUDstjSm-AUz4WMF9VteiydcEb5opnJ_gT4F7ag@mail.gmail.com>
 <CAKOb=Yb7NMm26=u+-0ywMk543WdXc5uiO2omY4=TXpRxPrOWHg@mail.gmail.com>
 <CAFOYbcn3HpRaaoSPWF5OL6QJCec-Zb2+NySqjgqyOXHRaXD26Q@mail.gmail.com>
 <5159AB72.1050202@gmail.com>
 <CAKOb=YbDW2kMhnAPUetsGeNdtiaOCOmQ2X-9GXW18wwSUZ8j-A@mail.gmail.com>
 <515ADACD.8010108@gmail.com>
 <CAKOb=Ybh=_w5ZSB+64bxpzBanheJvMhwd9Pus7sJet9ihn5jSA@mail.gmail.com>
 <515AEF67.4070206@gmail.com>
 <CAKOb=YbopNZ0yRovKOhsDcwYEX-d0RpyS+xGoWQAZo2gU3irAg@mail.gmail.com>
 <CAKOb=Yan9b2LS_WbsMwQEkkN0+WRpx8eC1x0arVrVYYC1gXngQ@mail.gmail.com>
 <515B46B8.5050806@gmail.com>
 <CAKOb=YZA6m5UrBiTmMcx6dTYzK4f67+UZYOEN_Lj+i9_pMcCRQ@mail.gmail.com>
 <CAJ-VmokAMn_gHqEWbywWEkqa0MZrjgEZCbrx1yn0b=X9A84CzQ@mail.gmail.com>
Date: Tue, 2 Apr 2013 15:54:02 -0700
Message-ID: <CAKOb=YaarQ+GtppUDXHxh50VjNhQ54HE80t_gKWt0yLav0bc7Q@mail.gmail.com>
Subject: Re: igb and ALTQ in 9.1-rc3
From: Nick Rogers <ncrogers@gmail.com>
To: Adrian Chadd <adrian@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: Karim Fodil-Lemelin <fodillemlinkarim@gmail.com>,
 "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>,
 "jfvogel@gmail.com" <jfvogel@gmail.com>
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Apr 2013 22:54:03 -0000

On Tue, Apr 2, 2013 at 3:39 PM, Adrian Chadd <adrian@freebsd.org> wrote:
> Yes:
>
> * you need to add it to conf/options - see if there's an opt_igb.h to
> add it to, otherwise you'll need to add one;
> * Make sure the driver code includes opt_igb.h;
> * Then make sure you make kernel modules using either make buildkernel
> KERNCONF=X, or you set the environment appropriately so the build
> scripts can find your kernel build directory (where it populates all
> the opt_xxx.h includes) and it'll have this module set.

Thanks, I figured as much.

>
> Hopefully Jack will do this.

This should probably be done for EM_MULTIQUEUE and IGB_LEGACY_TX options.

>
> Yes, we need a better queue management discipline API in the kernel.
> Jacks' just falling afoul of the fact we don't have one. It's not his
> fault.

No blame from me... He's been very helpful so far as always.

>
>
>
> adrian