From owner-cvs-all@FreeBSD.ORG Thu Mar 18 15:10:45 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 535D816A4CE; Thu, 18 Mar 2004 15:10:45 -0800 (PST) Received: from mta7.pltn13.pbi.net (mta7.pltn13.pbi.net [64.164.98.8]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4010343D2D; Thu, 18 Mar 2004 15:10:45 -0800 (PST) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (7dd5ca28d1fe6d42ae3811114182f88b@adsl-67-119-53-203.dsl.lsan03.pacbell.net [67.119.53.203])i2INAi1w007449; Thu, 18 Mar 2004 15:10:44 -0800 (PST) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 1D6BF51BB5; Thu, 18 Mar 2004 15:10:44 -0800 (PST) Date: Thu, 18 Mar 2004 15:10:43 -0800 From: Kris Kennaway To: Nakata Maho Message-ID: <20040318231043.GA97848@xor.obsecurity.org> References: <200403171047.i2HAlUsL048731@repoman.freebsd.org> <20040317111525.GA62305@xor.obsecurity.org> <20040319.081248.846937474.chat95@mac.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="EVF5PPMfhYS0aIcm" Content-Disposition: inline In-Reply-To: <20040319.081248.846937474.chat95@mac.com> User-Agent: Mutt/1.4.2.1i cc: maho@FreeBSD.org cc: cvs-ports@FreeBSD.org cc: ports-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: kris@obsecurity.org Subject: Re: cvs commit: ports/biology/pymol Makefile distinfo pkg-plist ports/biology/pymol/files patch-Rules.make patch-setup+pymol+com+linux-rh7x X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Mar 2004 23:10:45 -0000 --EVF5PPMfhYS0aIcm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 19, 2004 at 08:12:48AM +0900, Nakata Maho wrote: > In Message-ID: <20040317111525.GA62305@xor.obsecurity.org>=20 > Kris Kennaway wrote: >=20 > > On Wed, Mar 17, 2004 at 02:47:29AM -0800, Maho Nakata wrote: > >=20 > > > | +.if !defined(PICFLAG) > > > | +.if ${MACHINE_ARCH} =3D=3D "sparc64" > > > | +PICFLAG=3D-fPIC > > > | +.else > > > | +PICFLAG=3D-fpic > > > | +.endif > > > | +.endif > >=20 > > As far as I understand, there's no need to treat these differently: > > -fPIC is appropriate on all architectures. >=20 > Wow, thanks! > Committed to math/atlas, math/atlas-devel, biology/pymol Actually...obrien followed up to my mail and pointed out that -fpic is a minor optimization over -fPIC when you can get away with it. That depends on the architecture and the program, so it needs to be tested. Kris --EVF5PPMfhYS0aIcm Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAWixzWry0BWjoQKURAmXiAKC14gqt5AgNwiH0Q3dmzIkU0S3KJwCdELNW YK331+d/e6EGAgZx0KvY8pc= =+yly -----END PGP SIGNATURE----- --EVF5PPMfhYS0aIcm--