From owner-cvs-all Fri Feb 7 21:47:37 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A865237B401; Fri, 7 Feb 2003 21:47:32 -0800 (PST) Received: from sccrmhc03.attbi.com (sccrmhc03.attbi.com [204.127.202.63]) by mx1.FreeBSD.org (Postfix) with ESMTP id 84C4343F3F; Fri, 7 Feb 2003 21:47:31 -0800 (PST) (envelope-from julian@elischer.org) Received: from interjet.elischer.org (12-232-168-4.client.attbi.com[12.232.168.4]) by sccrmhc03.attbi.com (sccrmhc03) with ESMTP id <2003020805472400300siikde>; Sat, 8 Feb 2003 05:47:25 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id VAA23526; Fri, 7 Feb 2003 21:47:23 -0800 (PST) Message-Id: <200302080547.VAA23526@InterJet.elischer.org> Date: Fri, 7 Feb 2003 21:47:22 -0800 (PST) From: Julian Elischer To: Scott Long Cc: Julian Elischer , src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, legacy-committers@freebsd.org Subject: Re: cvs commit: src/sys/sys proc.h src/sys/kern kern_clock.c Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG kern_exit.c subr_prof.c In-Reply-To: <3E447A2C.2070405@btc.adaptec.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII On Fri, 7 Feb 2003, Scott Long wrote: > Julian Elischer wrote: > > > julian 2003/02/07 18:58:16 PST > > > > Modified files: > > sys/sys proc.h > > sys/kern kern_clock.c kern_exit.c subr_prof.c > > Log: > > A little infrastructure, preceding some upcoming changes > > to the profiling and statistics code. > > > > Submitted by: DavidXu@ > > Reviewed by: peter@ > > > > Revision Changes Path > > 1.147 +19 -3 src/sys/kern/kern_clock.c > > 1.193 +1 -1 src/sys/kern/kern_exit.c > > 1.61 +46 -21 src/sys/kern/subr_prof.c > > 1.292 +3 -1 src/sys/sys/proc.h > > > For us trying to keep score on the sidelines, could you explain this a > little more? > A bunch of statistics are going to move from the kse struct to the thread struct, (It's a long story) and this allows us to do better profiling on threaded programs, but before we do that we need to ensure that a thread turning off profiling doesn't do so while other threads are working in the profiling code. That's what this patch does. This has basically no effect on non KSE processes. Puting some of these small patches in independently allows the reviewers to understand each one easily and be sure that they are not breaking normal functionality. It also makes the bigger patches (coming) more managable by removing the distracting but irrellevent code out. This allows the KSE developers and reviewers to concentrate on the more 'dangerous' changes. > Thanks! > > Scott > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message