From owner-dev-commits-src-all@freebsd.org Fri Mar 5 20:27:38 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2F6B4565F7B; Fri, 5 Mar 2021 20:27:38 +0000 (UTC) (envelope-from se@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DsfRt0fgHz3h8p; Fri, 5 Mar 2021 20:27:38 +0000 (UTC) (envelope-from se@freebsd.org) Received: from Stefans-MBP-449.fritz.box (p200300cd5f26c90000a9e0dfe348cc0e.dip0.t-ipconnect.de [IPv6:2003:cd:5f26:c900:a9:e0df:e348:cc0e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4F7B8C118; Fri, 5 Mar 2021 20:27:37 +0000 (UTC) (envelope-from se@freebsd.org) To: Kyle Evans , John Baldwin Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202103051755.125HtZsc073704@gitrepo.freebsd.org> From: Stefan Esser Subject: Re: git: bb6e84c988d3 - main - poly1305: Don't export generic Poly1305_* symbols from xform_poly1305.c. Message-ID: <3e76fccd-efeb-1479-7418-7e69bed98915@freebsd.org> Date: Fri, 5 Mar 2021 21:27:35 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BzEcQZ2nusRpdURvGKXTcE63zI1f9CPzu" X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Mar 2021 20:27:38 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BzEcQZ2nusRpdURvGKXTcE63zI1f9CPzu Content-Type: multipart/mixed; boundary="j85mRpT9Yj12HfXzWxaH0rMreDxXIgaOS"; protected-headers="v1" From: Stefan Esser To: Kyle Evans , John Baldwin Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Message-ID: <3e76fccd-efeb-1479-7418-7e69bed98915@freebsd.org> Subject: Re: git: bb6e84c988d3 - main - poly1305: Don't export generic Poly1305_* symbols from xform_poly1305.c. References: <202103051755.125HtZsc073704@gitrepo.freebsd.org> In-Reply-To: --j85mRpT9Yj12HfXzWxaH0rMreDxXIgaOS Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: de-DE Content-Transfer-Encoding: quoted-printable Am 05.03.21 um 21:05 schrieb Kyle Evans: > On Fri, Mar 5, 2021 at 11:55 AM John Baldwin wrote: >> >> The branch main has been updated by jhb: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3Dbb6e84c988d3f54eff602ed= 544ceaa9b9fe3e9ff >> >> commit bb6e84c988d3f54eff602ed544ceaa9b9fe3e9ff >> Author: John Baldwin >> AuthorDate: 2021-03-05 17:47:58 +0000 >> Commit: John Baldwin >> CommitDate: 2021-03-05 17:55:11 +0000 >> >> poly1305: Don't export generic Poly1305_* symbols from xform_poly= 1305.c. >> >> There currently isn't a need to provide a public interface to a >> software Poly1305 implementation beyond what is already available= via >> libsodium's APIs and these symbols conflict with symbols shared w= ithin >> the ossl.ko module between ossl_poly1305.c and ossl_chacha20.c. >> >> Reported by: se, kp >> Fixes: 78991a93eb9d >> Sponsored by: Netflix >> --- >> sys/opencrypto/xform_poly1305.c | 43 ++++++++++++-------------------= ---------- >> sys/opencrypto/xform_poly1305.h | 16 --------------- >> 2 files changed, 12 insertions(+), 47 deletions(-) >=20 > xform_poly1305.h also needs to stop being grouped in > ^/include/Makefile (reported by jenkins via np) AFAICT, sys/opencrypto/xform_poly1305.h needs to be restored ... It is needed during buildworld (and present in stable/13). --j85mRpT9Yj12HfXzWxaH0rMreDxXIgaOS-- --BzEcQZ2nusRpdURvGKXTcE63zI1f9CPzu Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmBClDcFAwAAAAAACgkQR+u171r99UTc twgAy0d3y7gmaUC8ZWEpJtgBKNbCA8PYAHFOSrTe6KHMewnoZd+kqCgyTptRSsywRNrPd4Xy1f7H Tm4to/+uPWQwo5v6yjn3xCGDQbpN2eK92If8mKhARd5G1ygFTLuzZ/PONch7kZw09+/pY5iACovc dhXliI8MlRppsTr7YE/YaGQeNIWgMgJyMPoaCrRO/ixj0nYK2eJXCZtG5Y2TwnBr+o+E+Nd6kK3X GhwrnCx5fcmi8JqCWiSlenht3V/cibHsbA49Hpc0LVpZp80DPW4S1Z0/rl/X+wEZWTG217hWAe+m yaocY1dLiWy6jicgAa4LNKThDFIbDYg2fhJ42ALk7Q== =Yto1 -----END PGP SIGNATURE----- --BzEcQZ2nusRpdURvGKXTcE63zI1f9CPzu--