From owner-freebsd-net  Mon Jan 13 14:11:22 2003
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3404B37B401; Mon, 13 Jan 2003 14:11:21 -0800 (PST)
Received: from mail.imp.ch (mail.imp.ch [157.161.1.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C3E6643ED8; Mon, 13 Jan 2003 14:11:19 -0800 (PST)
	(envelope-from mb@imp.ch)
Received: from levais.imp.ch (levais.imp.ch [157.161.4.66])
	by mail.imp.ch (8.12.6/8.12.3) with ESMTP id h0DMBDae060058;
	Mon, 13 Jan 2003 23:11:13 +0100 (CET)
	(envelope-from Martin.Blapp@imp.ch)
Date: Mon, 13 Jan 2003 23:11:20 +0100 (CET)
From: Martin Blapp <mb@imp.ch>
To: Thomas Moestl <tmoestl@gmx.net>
Cc: current@freebsd.org, "" <net@freebsd.org>
Subject: Re: PANIC in tcp_syncache.c sonewconn() line 562
In-Reply-To: <20030113215318.GA278@crow.dom2ip.de>
Message-ID: <20030113230616.B74437@levais.imp.ch>
References: <20030113173957.T73725@levais.imp.ch> <20030113215318.GA278@crow.dom2ip.de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-net.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-net>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-net>
X-Loop: FreeBSD.org


Hi Thomas,

> The solution should be to reject the listen() with EINVAL (which seems
> to be that standard-mandated error for connected sockets); patch
> attached.

Cool, thank you for the proposed solution. I suspected something like this;
rpcgen does generate quite broken code sometimes, and nobody cared about
fixing these old bugs. :-(

Since rpcgen in STABLE is broken too, it's not my fault ;)

I'll provide a rpcgen patch too which has the call to
listen() removed (in the inetd case) after the socket
is already connected.

I guess a "rpcgen -I" generated server should knew about this issue and
test properly if it is run standalone or from inetd. The solution I think
would be to reuse the socket. I'll provide a fix for this !

Martin

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message