From owner-freebsd-standards@freebsd.org Thu Jan 31 16:32:28 2019 Return-Path: Delivered-To: freebsd-standards@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 60E5D14AF566 for ; Thu, 31 Jan 2019 16:32:28 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 42A899614E for ; Thu, 31 Jan 2019 16:32:24 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x833.google.com with SMTP id t13so4131203qtn.3 for ; Thu, 31 Jan 2019 08:32:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Cd1sac9PWGR0Cljca9x0qUJ0km+vlDGBoULcbGihn+4=; b=H5e4+yNNIEWlQVl3fvVWhVxJnEgE5CUUuY5gLOzdvk4qWuvM4FiPfAaxG9x9j0ie2e NGzh9tW86o+sZzK+OloHzrLNfKq9zJSZ857Mz2qct+oylEbZ5h88Vfdoanswx4AvaOam 8rMRKeUQWJyoFBqJo/MXrgsmotGdI9IsH/qkK+2pzyDvMDY5dgNJGwMWIrfIlKJjQvYI viLpW27QZ3NFCTTBaqb23n6PxA1opeNTSkWPcI9g96SKixUxWsevdVJfvh0rBRmwMdN3 nT5f+2ifoUdNfNan27Vfspy5UfXrq7vlOMLAqKQQ4zjd+kcoxT3HUuEAK6v5lz6ZiZfn rbCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Cd1sac9PWGR0Cljca9x0qUJ0km+vlDGBoULcbGihn+4=; b=c2q0vXLcoywufBstArOe/neurO6Oxn6ce6GlerHdESYo1LRMwZObxAX6Hr2HLPWdJY 9s01jcP221XPCYnpgO4gWlbmAX8yD1gqWODfcM6ig/ZZS+JuqaZeDPYO3S3boOCUYw9V tK+KkOOej/4lshNiHo8rvooTaBUQQW7Uc2QXAcEKD0qWZTpx1bRxYujye+J5dl1alqcI KOuwEhc/YYM6DnVgDL2XDR+DHs9+STyrPVcWIUvBTvgcLSKMW6WxLlvdQWSkvIrIJhE1 MUTCu91iQwjS0hxn0LA+zrtTFRYDFPrtlKb31/OoE2g+XsA4xUlNgV4cVBx5OAYL1IwP 7gnA== X-Gm-Message-State: AJcUukde2m0WEAJzGPG//fTYQFjsmVVBIZ3Ey0vvBAG0eaeM8U22JHZB aqM1fbOnfsNgyZKw44DsK++weZOsTb6LGkSJusiq8w== X-Google-Smtp-Source: ALg8bN7x+BR8wUZE7njQ+iDtd6h8Pk9cZPJmww721aJpnrDG8+N28QodxfnnYl0eM/fyineLLw/rfAqKQwt/YojC+/A= X-Received: by 2002:a0c:f143:: with SMTP id y3mr33589663qvl.21.1548952343389; Thu, 31 Jan 2019 08:32:23 -0800 (PST) MIME-Version: 1.0 References: <20190130212904.GA66299@troutmask.apl.washington.edu> In-Reply-To: <20190130212904.GA66299@troutmask.apl.washington.edu> From: Warner Losh Date: Thu, 31 Jan 2019 09:32:11 -0700 Message-ID: Subject: Re: Is libc C99 compliant? To: Steve Kargl Cc: FreeBSD Standards , "freebsd-toolchain@FreeBSD.org" X-Rspamd-Queue-Id: 42A899614E X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=H5e4+yNN X-Spamd-Result: default: False [-4.57 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; IP_SCORE(-2.63)[ip: (-8.56), ipnet: 2607:f8b0::/32(-2.55), asn: 15169(-1.97), country: US(-0.07)]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-standards@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[cached: ALT1.aspmx.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[3.3.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.93)[-0.933,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+,1:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 16:32:28 -0000 On Wed, Jan 30, 2019 at 11:33 PM Steve Kargl < sgk@troutmask.apl.washington.edu> wrote: > When building gcc file gcc/config/freebsd.c contains > > #define TARGET_LIBC_HAS_FUNCTION no_c99_libc_has_function > > In targhook.c, one finds > > /* By default we assume that c99 functions are present at the runtime, > but sincos is not. */ > bool > default_libc_has_function (enum function_class fn_class) > { > if (fn_class == function_c94 > || fn_class == function_c99_misc > || fn_class == function_c99_math_complex) > return true; > > return false; > } > > bool > no_c99_libc_has_function (enum function_class fn_class ATTRIBUTE_UNUSED) > { > return false; > } > > Shouldi/can TARGET_LIBC_HAS_FUNCTION be updated to at least > default_libc_has_function? More importantly now that libm > contains sincos[fl], should FreeBSD gcc config file be updated > to use > > bool > bsd_libc_has_function (enum function_class fn_class) > { > if (fn_class == function_c94 > || fn_class == function_c99_misc > || fn_class == function_c99_math_complex > || fn_class == function_sincos) > return true; > > return false; > } On its surface, this seems sane to me. what does this control? And is this for our ancient 4.2 or current gcc... Warner > > -- > Steve > _______________________________________________ > freebsd-toolchain@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain > To unsubscribe, send any mail to " > freebsd-toolchain-unsubscribe@freebsd.org" >