From owner-p4-projects@FreeBSD.ORG  Mon Sep  8 04:49:31 2014
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
 id 805C3DF2; Mon,  8 Sep 2014 04:49:31 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 0A3FF8D2
 for <perforce@freebsd.org>; Mon,  8 Sep 2014 04:49:21 +0000 (UTC)
Received: from skunkworks.freebsd.org (skunkworks.freebsd.org
 [IPv6:2001:1900:2254:2068::682:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E198B1A8F
 for <perforce@freebsd.org>; Mon,  8 Sep 2014 04:49:20 +0000 (UTC)
Received: from skunkworks.freebsd.org ([127.0.1.74])
 by skunkworks.freebsd.org (8.14.9/8.14.9) with ESMTP id s884nKk3020747
 for <perforce@freebsd.org>; Mon, 8 Sep 2014 04:49:20 GMT
 (envelope-from jmg@freebsd.org)
Received: (from perforce@localhost)
 by skunkworks.freebsd.org (8.14.9/8.14.9/Submit) id s884nKkI020744
 for perforce@freebsd.org; Mon, 8 Sep 2014 04:49:20 GMT
 (envelope-from jmg@freebsd.org)
Date: Mon, 8 Sep 2014 04:49:20 GMT
Message-Id: <201409080449.s884nKkI020744@skunkworks.freebsd.org>
X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to
 jmg@freebsd.org using -f
From: John-Mark Gurney <jmg@FreeBSD.org>
Subject: PERFORCE change 1198728 for review
To: Perforce Change Reviews <perforce@FreeBSD.org>
Precedence: bulk
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.18-1
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/p4-projects>,
 <mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects/>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
 <mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Sep 2014 04:49:31 -0000

http://p4web.freebsd.org/@@1198728?ac=10

Change 1198728 by jmg@jmg_carbon2 on 2014/08/14 18:57:09

	make _mulalpha an inline as it's only used once...
	
	update comment on what platform I tested it on that it was
	faster...

Affected files ...

.. //depot/projects/opencrypto/sys/opencrypto/gfmult.c#3 edit

Differences ...

==== //depot/projects/opencrypto/sys/opencrypto/gfmult.c#3 (text+ko) ====

@@ -40,7 +40,7 @@
 };
 
 /* calulate v * 2 */
-static struct gf128
+static inline struct gf128
 gf128_mulalpha(struct gf128 v)
 {
 	uint64_t mask;
@@ -167,7 +167,8 @@
  * ...
  * 2^4 + worda[63,60]*h^4+ ... + wordd[63,60]*h
  *
- * Passing/returning struct is .5% faster than passing in via pointer.
+ * Passing/returning struct is .5% faster than passing in via pointer on
+ * amd64.
  */
 static struct gf128
 gfmultword4(uint64_t worda, uint64_t wordb, uint64_t wordc, uint64_t wordd,