From owner-svn-src-all@freebsd.org Fri Jun 3 12:40:41 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 64003B685ED; Fri, 3 Jun 2016 12:40:41 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from kif.fubar.geek.nz (kif.fubar.geek.nz [178.62.119.249]) by mx1.freebsd.org (Postfix) with ESMTP id 27859145B; Fri, 3 Jun 2016 12:40:40 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from zapp (global-5-143.nat-2.net.cam.ac.uk [131.111.5.143]) by kif.fubar.geek.nz (Postfix) with ESMTPSA id B5CCED78FE; Fri, 3 Jun 2016 12:40:34 +0000 (UTC) Date: Fri, 3 Jun 2016 13:40:31 +0100 From: Andrew Turner To: Svatopluk Kraus Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r301266 - head/sys/arm/freescale/imx Message-ID: <20160603134031.7a038244@zapp> In-Reply-To: <201606031105.u53B5tVi073576@repo.freebsd.org> References: <201606031105.u53B5tVi073576@repo.freebsd.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2016 12:40:41 -0000 On Fri, 3 Jun 2016 11:05:55 +0000 (UTC) Svatopluk Kraus wrote: > Author: skra > Date: Fri Jun 3 11:05:55 2016 > New Revision: 301266 > URL: https://svnweb.freebsd.org/changeset/base/301266 > > Log: > Postpone allocation of IRQ resource to the time when interrupt > controller devices are attached. This has already been done for > bus_setup_intr(). > > There was no doubt that if someone wants to setup an interrupt, > corresponding interrupt controller device must already be attached. > However, the same must be valid for allocation of an interrupt > resource unless the allocation is done blindly, without any > information that such interrupt even exists. While it was done this > blind way before, it won't be possible after next INTRNG change. > > Modified: > head/sys/arm/freescale/imx/imx6_anatop.c > > Modified: head/sys/arm/freescale/imx/imx6_anatop.c > ============================================================================== > --- head/sys/arm/freescale/imx/imx6_anatop.c Fri Jun 3 > 10:28:06 2016 (r301265) +++ > head/sys/arm/freescale/imx/imx6_anatop.c Fri Jun 3 11:05:55 > 2016 (r301266) @@ -78,7 +78,6 @@ __FBSDID("$FreeBSD$"); > static struct resource_spec imx6_anatop_spec[] = { > { SYS_RES_MEMORY, 0, RF_ACTIVE }, > - { SYS_RES_IRQ, 0, RF_ACTIVE }, Why not mark it as optional? Andrew