From owner-svn-src-head@FreeBSD.ORG Tue Apr 16 04:20:05 2013 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id D6CC2E92; Tue, 16 Apr 2013 04:20:05 +0000 (UTC) (envelope-from keramida@ceid.upatras.gr) Received: from tux-cave.hellug.gr (tux-cave.hellug.gr [195.134.99.74]) by mx1.freebsd.org (Postfix) with ESMTP id 5350BB51; Tue, 16 Apr 2013 04:20:04 +0000 (UTC) X-Spam-Status: No X-Hellug-MailScanner-From: keramida@ceid.upatras.gr X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-2.9, required 5, autolearn=not spam, ALL_TRUSTED -1.00, BAYES_00 -1.90) X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-ID: r3G4JpGM001874 Received: from saturn.laptop (217-162-217-29.dynamic.hispeed.ch [217.162.217.29]) (authenticated bits=0) by tux-cave.hellug.gr (8.14.3/8.14.3/Debian-9.4) with ESMTP id r3G4JpGM001874 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 16 Apr 2013 07:19:59 +0300 Received: from saturn.laptop (localhost [127.0.0.1]) by saturn.laptop (8.14.4/8.14.4/Debian-2.1ubuntu1) with ESMTP id r3G4JiTk011526 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 16 Apr 2013 06:19:44 +0200 Received: (from keramida@localhost) by saturn.laptop (8.14.4/8.14.4/Submit) id r3G4Jh3F011523; Tue, 16 Apr 2013 06:19:43 +0200 X-Authentication-Warning: saturn.laptop: keramida set sender to keramida@ceid.upatras.gr using -f From: keramida@ceid.upatras.gr (=?utf-8?B?zpPOuc+Oz4HOs86/z4IgzprOtc+BzrE=?= =?utf-8?B?zrzOr860zrHPgg==?=) To: Dimitry Andric , Gregory Shapiro Subject: Re: svn commit: r246880 - in head: lib/libsm libexec/mail.local libexec/smrsh share/mk usr.bin/vacation usr.sbin/sendmail References: <201302162017.r1GKHVdY022667@svn.freebsd.org> Date: Tue, 16 Apr 2013 06:19:43 +0200 In-Reply-To: <201302162017.r1GKHVdY022667@svn.freebsd.org> (Dimitry Andric's message of "Sat, 16 Feb 2013 20:17:31 +0000 (UTC)") Message-ID: <87a9ozayzk.fsf@saturn.laptop> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Apr 2013 04:20:05 -0000 On Sat, 16 Feb 2013 20:17:31 +0000 (UTC), Dimitry Andric wrote: > Author: dim > Date: Sat Feb 16 20:17:31 2013 > New Revision: 246880 > URL: http://svnweb.freebsd.org/changeset/base/246880 > > Log: > Since clang 3.2 now has an option to suppress warnings about implicitly > promoted K&R parameters, remove the workarounds added for sendmail > components in r228558. > > MFC after: 1 week > Modified: head/usr.sbin/sendmail/Makefile > ============================================================================== > --- head/usr.sbin/sendmail/Makefile Sat Feb 16 19:11:57 2013 (r246879) > +++ head/usr.sbin/sendmail/Makefile Sat Feb 16 20:17:31 2013 (r246880) > @@ -45,11 +45,6 @@ CFLAGS+= -DNETINET6 > > WARNS?= 1 > > -# Unfortunately, clang gives warnings about sendmail code that cannot > -# be turned off yet. Since this is contrib code, and we don't really > -# care about the warnings, just make them non-fatal for now. > -NO_WERROR.clang= > - > DPADD= ${LIBUTIL} ${LIBWRAP} > LDADD= -lutil -lwrap The part of the commit that removes NO_WERROR.clang for usr.sbin/sendmail/ breaks the build of Sendmail with -DSASL. I just tried rebuilding Sendmail with the following in "/etc/make.conf": # Build Sendmail with SASL support. SENDMAIL_CFLAGS ?= -I/usr/local/include -DSASL=20126 SENDMAIL_LDFLAGS ?= -L/usr/local/lib SENDMAIL_LDADD ?= -lsasl2 The warnings that usersmtp.c still triggers when -DSASL is used are: : cc -O2 -pipe -I/usr/src/usr.sbin/sendmail/../../contrib/sendmail/src -I/usr/src/usr.sbin/sendmail/../../contrib/sendmail/include -I. -DNEWDB -DNIS -DTCPWRAPPERS -DMAP_REGEX -DDNSMAP -DNETINET6 -DSTARTTLS -D_FFR_TLS_1 -I/usr/local/include -DSASL=20126 -std=gnu99 -Qunused-arguments -fstack-protector -Wsystem-headers -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-conversion -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -Wno-parentheses -c /usr/src/usr.sbin/sendmail/../../contrib/sendmail/src/usersmtp.c : /usr/src/usr.sbin/sendmail/../../contrib/sendmail/src/usersmtp.c:1797:50: warning: incompatible pointer types passing 'void ()' to parameter of type 'void (*)(char *, bool, MAILER *, struct : mailer_con_info *, ENVELOPE *)' [-Wincompatible-pointer-types] : smtpresult = reply(m, mci, e, TimeOuts.to_auth, getsasldata, NULL, : ^~~~~~~~~~~ : /usr/src/usr.sbin/sendmail/../../contrib/sendmail/src/sendmail.h:2519:67: note: passing argument to parameter here : extern int reply __P((MAILER *, MCI *, ENVELOPE *, time_t, void (*)__P((char *, bool, MAILER *, MCI *, ENVELOPE *)), char **, int)); : ^ : /usr/include/sys/cdefs.h:136:21: note: expanded from macro '__P' : #define __P(protos) protos /* full-blown ANSI C */ : ^ : /usr/src/usr.sbin/sendmail/../../contrib/sendmail/src/usersmtp.c:1842:9: warning: incompatible pointer types passing 'void ()' to parameter of type 'void (*)(char *, bool, MAILER *, struct : mailer_con_info *, ENVELOPE *)' [-Wincompatible-pointer-types] : getsasldata, NULL, XS_AUTH); : ^~~~~~~~~~~ : /usr/src/usr.sbin/sendmail/../../contrib/sendmail/src/sendmail.h:2519:67: note: passing argument to parameter here : extern int reply __P((MAILER *, MCI *, ENVELOPE *, time_t, void (*)__P((char *, bool, MAILER *, MCI *, ENVELOPE *)), char **, int)); : ^ : /usr/include/sys/cdefs.h:136:21: note: expanded from macro '__P' : #define __P(protos) protos /* full-blown ANSI C */ : ^ : /usr/src/usr.sbin/sendmail/../../contrib/sendmail/src/usersmtp.c:1864:8: warning: incompatible pointer types passing 'void ()' to parameter of type 'void (*)(char *, bool, MAILER *, struct : mailer_con_info *, ENVELOPE *)' [-Wincompatible-pointer-types] : getsasldata, NULL, XS_AUTH); : ^~~~~~~~~~~ : /usr/src/usr.sbin/sendmail/../../contrib/sendmail/src/sendmail.h:2519:67: note: passing argument to parameter here : extern int reply __P((MAILER *, MCI *, ENVELOPE *, time_t, void (*)__P((char *, bool, MAILER *, MCI *, ENVELOPE *)), char **, int)); : ^ : /usr/include/sys/cdefs.h:136:21: note: expanded from macro '__P' : #define __P(protos) protos /* full-blown ANSI C */ : ^ : 3 warnings generated. We have to either fix the warnings in the contrib/sendmail/src/usersmtp.c code or put back NO_WERROR.clang, at least for usr.sbin/sendmail/Makefile.