From owner-svn-src-all@freebsd.org Sun May 22 02:04:52 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 22516B4344B for ; Sun, 22 May 2016 02:04:52 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lb0-f193.google.com (mail-lb0-f193.google.com [209.85.217.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AB7AB10EC for ; Sun, 22 May 2016 02:04:51 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by mail-lb0-f193.google.com with SMTP id mx9so7395085lbb.2 for ; Sat, 21 May 2016 19:04:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=cm2CZxXkYU2IicJHMe6FExtcQ1nEhROEagDaHKmLTy8=; b=gZDC1EwlQohsG3Ghf/K1VOPHYMbrCzPzW9q6rkgcntqBTlFCz/Eli/uGWPqFPu/sR4 CcQy53bEOr1aWJiWk4uEIAz51L//jaGG7VRCzf9nA62EE79GTMr2YYAR6JtTmpLG+YAj x/ADmdr/jXhRXF58wXIp9AYlu6zEaqFDBKqo0+49IYA/ujbt0RgE+Hq1ugML49HeKF+w chwYbrofMq3imh7JpWWFQB0foLKW3CyFj7UeR6Lxl1KgMiJWjipFrlKRITR2G0b7UiSj JtEPHzTnvV55+1ykFq1qgoITxHzPNTsu5+X0crVNfMnUiFTDHx2kavbGEXPT/ZAIfSCl Q5yw== X-Gm-Message-State: AOPr4FXAYnfeLGuCU1p8+1RHM5lGqcD2zWo29NzOUzfAsT0gipzZNww8mpsH8fH+YUlPZA== X-Received: by 10.112.65.71 with SMTP id v7mr3655138lbs.52.1463881566943; Sat, 21 May 2016 18:46:06 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id dw6sm4466361lbc.10.2016.05.21.18.46.05 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 21 May 2016 18:46:06 -0700 (PDT) Subject: Re: svn commit: r300384 - head/sys/compat/ndis To: "Pedro F. Giffuni" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201605220029.u4M0TPI6050123@repo.freebsd.org> From: Andrey Chernov Message-ID: <82b74a0b-7551-31ed-6b89-42925e072900@freebsd.org> Date: Sun, 22 May 2016 04:46:03 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <201605220029.u4M0TPI6050123@repo.freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 May 2016 02:04:52 -0000 On 22.05.2016 3:29, Pedro F. Giffuni wrote: > static void > srand(unsigned int seed) > { > > + if (seed == 0) > + seed = 1; > srandom(seed); > } IMHO it is not needed. srandom() already handles seed == 0 case, there is no point to remap it to another constant.