Date: Thu, 2 Apr 2015 06:53:36 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Olivier Duchateau <olivierd@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r382900 - in head: Mk audio/musicpd audio/xmms2 multimedia/xfce4-parole Message-ID: <20150402065336.GE89620@FreeBSD.org> In-Reply-To: <20150401194658.8fea9919a99b58f74386961c@freebsd.org> References: <201504010930.t319Uncw071055@svn.freebsd.org> <20150401194658.8fea9919a99b58f74386961c@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 01, 2015 at 07:46:58PM +0000, Olivier Duchateau wrote: > On Wed, 1 Apr 2015 09:30:49 +0000 (UTC) > Alexey Dokuchaev <danfe@FreeBSD.org> wrote: > > Log: > > - Provide standard CDDA_DESC for Digital Audio CD support, and remove > > it from individual ports when appropriate [...] > > Just for clarification, in multimedia/xfce4-parole CDDA option installs > audio/gstreamer(1)-plugins-cdparanoia not audio/cparanoia. CDDA_DESC is aimed to be an accurate, but still generic description of support for Compact Disc Digital Audio technology and/or media. It does not imply any particular implementation. > I hope it's not just "grep" in ports tree. Of course it was (find ... | xargs grep CDDA_DESC). Then reading the Makefile and trying to understand if that port's CDDA_DESC can be replaced with default one. Do you see anything wrong with this approach? In the `multimedia/xfce4-parole' case, it was "CD audio (cdparanoia)". Note that it's a bit scarse as it was. Also, there is no other "CD audio (foobar)" counterpart. Given that, I decided that it was safe to drop it from there. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150402065336.GE89620>