From owner-cvs-all  Thu Mar 25  2: 0:12 1999
Delivered-To: cvs-all@freebsd.org
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.26.10.9])
	by hub.freebsd.org (Postfix) with ESMTP
	id 571FD14F3A; Thu, 25 Mar 1999 01:59:54 -0800 (PST)
	(envelope-from bde@godzilla.zeta.org.au)
Received: (from bde@localhost)
	by godzilla.zeta.org.au (8.8.7/8.8.7) id UAA20045;
	Thu, 25 Mar 1999 20:59:32 +1100
Date: Thu, 25 Mar 1999 20:59:32 +1100
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199903250959.UAA20045@godzilla.zeta.org.au>
To: bde@zeta.org.au, luigi@labinfo.iet.unipi.it
Subject: Re: cvs commit: src/sys/netinet ip_dummynet.c
Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org,
	luigi@FreeBSD.org, mike@smith.net.au
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

>since you opened the discussion on option names: do you have a better
>name for BRIDGE ? something like NET_BRIDGE or so ?

Something like that.

>There is another thing: having to explicitly include "opt_foo.h" in all
>files related to "foo" opens the door to subtle bugs that might not be
>detected at compile time or might even cause inconsistent behaviour at
>run time.

Problems are fairly easy to avoid in new code.  Before using `#ifdef FOO',
include "opt_foo.h" if it isn't already included.  If someone put option
FOO in "opt_youll_never_guess_whats_in_here.h", then complain to this
list about badly named options files :-).

>I understand that name space pollution issues do not leave the option
>of having all "opt_*" included in "opt_global.h" unless we standardize names
>in a way that reduces conflicts... So should we go for that, e.g. having
>
>	OPT_*	for generic options
>	DEV_*	for devices

Something like that, but not so generic.  One prefix for the appropriate
level is probably sufficient.  Drivers xx should use XX_.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message