Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 31 Mar 2018 14:42:01 +0200
From:      Dimitry Andric <dim@FreeBSD.org>
To:        Antoine Brodin <antoine@freebsd.org>
Cc:        re <re@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   Re: svn commit: r331838 - in stable/11: . contrib/compiler-rt/include/sanitizer contrib/compiler-rt/include/xray contrib/compiler-rt/lib/BlocksRuntime contrib/compiler-rt/lib/asan contrib/compiler-rt/l...
Message-ID:  <68DEEF9A-6290-40AD-B51D-E187593C089F@FreeBSD.org>
In-Reply-To: <CAALwa8mB-FWA%2B_tKXO19x%2B9_CKy6%2B80vxqbKieEXY9fre1ZPdg@mail.gmail.com>
References:  <201803311138.w2VBcKHP014025@repo.freebsd.org> <CAALwa8mB-FWA%2B_tKXO19x%2B9_CKy6%2B80vxqbKieEXY9fre1ZPdg@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_F7837E48-7DD6-4409-834B-4C6989E311A9
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

On 31 Mar 2018, at 14:25, Antoine Brodin <antoine@freebsd.org> wrote:
> 
> On Sat, Mar 31, 2018 at 11:38 AM, Dimitry Andric <dim@freebsd.org> wrote:
>> Author: dim
>> Date: Sat Mar 31 11:38:16 2018
>> New Revision: 331838
>> URL: https://svnweb.freebsd.org/changeset/base/331838
>> 
>> Log:
>>  Merge clang, llvm, lld, lldb, compiler-rt and libc++ 6.0.0 release, and
>>  several follow-up fixes.
> ...
> Index: CompilerInvocation.cpp
> ===================================================================
> --- CompilerInvocation.cpp      (revision 331837)
> +++ CompilerInvocation.cpp      (revision 331838)
> ...
> @@ -1690,11 +1765,7 @@
>       break;
>     case InputKind::CXX:
>     case InputKind::ObjCXX:
> -      // The PS4 uses C++11 as the default C++ standard.
> -      if (T.isPS4())
> -        LangStd = LangStandard::lang_gnucxx11;
> -      else
> -        LangStd = LangStandard::lang_gnucxx98;
> +      LangStd = LangStandard::lang_gnucxx14;
>       break;
>     case InputKind::RenderScript:
>       LangStd = LangStandard::lang_c99;
> ...
> 
> Hi,
> 
> Is it safe to change the default c++ standard from gnu++98 to gnu++14
> in a stable branch?
> Around 380 ports are still broken by the gnu++98 -> gnu++14 switch.

It's an upstream choice, which also corresponds to what gcc 6 and higher
have been doing for a longer time.  It's been almost 3 months now since
clang 6 landed in head, and if those ports require USE_CXXSTD=gnu++98 to
be fixed, why haven't those already been changed already?

That said, I'll be happy to go over the list and push in patches, if it
is simply to due to lack of maintainer time.

-Dimitry


--Apple-Mail=_F7837E48-7DD6-4409-834B-4C6989E311A9
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.2

iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCWr+CGQAKCRCwXqMKLiCW
oykeAJ9rHbKOL9MItTy/sb6xEqclUAaOzgCgkQJpK15rg2ymy87gvhZNAmCEtmQ=
=ZVDS
-----END PGP SIGNATURE-----

--Apple-Mail=_F7837E48-7DD6-4409-834B-4C6989E311A9--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?68DEEF9A-6290-40AD-B51D-E187593C089F>