From owner-svn-ports-head@FreeBSD.ORG Fri Mar 20 20:40:14 2015 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A283C1A1 for ; Fri, 20 Mar 2015 20:40:14 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7F6878B3 for ; Fri, 20 Mar 2015 20:40:14 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t2KKeEd9090450 for ; Fri, 20 Mar 2015 20:40:14 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t2KKeE7s090449 for svn-ports-head@freebsd.org; Fri, 20 Mar 2015 20:40:14 GMT (envelope-from bdrewery) Received: (qmail 47401 invoked from network); 20 Mar 2015 15:40:09 -0500 Received: from unknown (HELO ?10.10.1.139?) (freebsd@shatow.net@10.10.1.139) by sweb.xzibition.com with ESMTPA; 20 Mar 2015 15:40:09 -0500 Message-ID: <550C85B0.5050902@FreeBSD.org> Date: Fri, 20 Mar 2015 15:40:16 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Adam Weinberger , Baptiste Daroussin Subject: Re: svn commit: r381760 - in head/x11-fonts/sourcesanspro-ttf: . files References: <201503201823.t2KIN32I080448@svn.freebsd.org> <550C6655.5010802@FreeBSD.org> <20150320183524.GD87678@ivaldir.etoilebsd.net> <9BE33FCA-5C2F-4FEA-9B3A-5D9DB6632635@adamw.org> <550C6B34.8020401@FreeBSD.org> In-Reply-To: <550C6B34.8020401@FreeBSD.org> OpenPGP: id=6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6VXAHgrEG18h8UkDbjDdwfH7OeP86vbko" Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2015 20:40:14 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6VXAHgrEG18h8UkDbjDdwfH7OeP86vbko Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 3/20/2015 1:47 PM, Bryan Drewery wrote: > On 3/20/2015 1:43 PM, Adam Weinberger wrote: >> >>> On 20 Mar, 2015, at 12:35, Baptiste Daroussin wrot= e: >>> >>> On Fri, Mar 20, 2015 at 01:26:29PM -0500, Bryan Drewery wrote: >>>> On 3/20/2015 1:23 PM, Baptiste Daroussin wrote: >>>>> +WRKSRC=3D ${WRKDIR}/${GH_PROJECT}-${GH_TAGNAME:S,/,-,} >>>> >>>> I think we should put this globally in this 1 line: >>>> >>>> bsd.port.mk >>>> 1561 . if defined(GH_TAGNAME) >>>> 1562 WRKSRC?=3D ${WRKDIR}/${GH_PROJECT}-${GH_TAGNAME} >>>> >>>> >>>> After https://reviews.freebsd.org/D2103 is resolved I will fix that.= >>> >>> Almost in this case upstream decided to put a / in the TAGNAME which = is ... well >>> ... :) >> >> It would be so unbelievably nice if we had a way to just specify the d= estination filename, using fetch -o. All the bizarre names that files are= published as, the unversioned tarballs, the documentation files labelled= Documentation.pdf, and the fallout from changes like this.... we could m= ake our lives so much easier with a DISTFILE_DEST variable. >> >> # Adam >> >> >=20 > For USE_GITHUB that is exactly what DISTNAME is. You can name it > whatever you want. >=20 > As for your other examples I agree. I'll look into that! >=20 Thinking about it a bit more I don't have time to implement this today or soon. DISTFILES would need a syntax to specify an output filename. The do-fetch and do-checksum targets in bsd.port.mk would need a lot of rework. They are very risky to touch and hard to maintain as is. Ideas for a DISTFILES format? --=20 Regards, Bryan Drewery --6VXAHgrEG18h8UkDbjDdwfH7OeP86vbko Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVDIWwAAoJEDXXcbtuRpfPU9YIAK04Gn0HzccGVySKcYTUpZRI ZbAUnqq6yzSnT3PLF74bQaW4zRZLKsNVhjgSONbohul+aVOnvX+FPNSHQrostMmK mOgBord7uD5IGi32wFQIin5SCNi/fJlNU0O9yi9x+GDELtXoaoif4jIApurxSrQT 2idJPb/i9JsgoLMi610/Rgf6F37nVx13GgcbcQYjSv5Z7cOjc2paCccaPKP2Iqm+ RovIk+4muAc2lGERfh3kMaejXx8OVBoHXYIXbtDjWRqttl9cGblZPIZcSVpMW3Ao 8r0kE0aHiS5SHYf5sclmXujsmMxeoZcQe2lFr8dYHqzcgTb9ZnXv6wXLqGcKLRg= =U0bT -----END PGP SIGNATURE----- --6VXAHgrEG18h8UkDbjDdwfH7OeP86vbko--