From owner-svn-src-all@freebsd.org Sun Mar 10 22:16:47 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B70D1543E35; Sun, 10 Mar 2019 22:16:47 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8A55269FCA; Sun, 10 Mar 2019 22:16:46 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: by mail-io1-xd29.google.com with SMTP id x7so2387018ioh.4; Sun, 10 Mar 2019 15:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IHytSaQ6EJ324Ue0TZ9cEVRU2rOkd8RaevOciEgCR4U=; b=Xvs/yOVMU0zBSdAzS2Bwq2oy5G/3JuLODBaDCMAo6RaO+xaCLqA11QlYzrkn9jCTMg XLNYMr0l8QfKMFHEenpLt3zqQDcoBtcd9qGY6V4DGMRKrrOU1K9wavGfRJ4AJfTr3t/o 16q4IkktoKtAhK8WgqZkfhFh7nWEWL3df7tBprs0LgQ5HtP7C5lnRfa8lq3HmrZhRE/b 7tB+GX8M+e+05GfFHoC56MbBUy7o612jDQHAvEUPdgx9x4AIdeZxrhocey7WiO20o2Ql Ef0L8gR2VNDYs4XfZ3CWO1Z15MaP6qGWxk/67ATuE2EW1Q4L/JXqsVzXM5Wk2Zp+8VDe 409A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IHytSaQ6EJ324Ue0TZ9cEVRU2rOkd8RaevOciEgCR4U=; b=Z9Uty2ru/cMXpKfikvtJEVjoVZvTxETj7BAwiG6NlknC6es6rqXHjSItRirR36sHsT 9U/Ovjs7sNaWLGdEi/L14ESNZZEEUBHONMLBvz8IdQ58wzSr8brvb2+owDtjPVhJLLI3 O9lduTvwfQjIV4YrcjSTnxGVwzrUaI71/J4EnIlLS8HjY+UI8Y5DyoAHPEQRM6yn8AMS FLKlUoPh4h9ex99ShQ+F/AAC4DDHZ+HFBnTHoaA5BLEg8iRKr/bUJ643Icwwmnat/QIl hrOWRQEGdMHxZBmBDfo5F83QnpM6CP8VlYQdsOGBMSYpKcRivKll4txTt7KmMzpqhmkg BUzw== X-Gm-Message-State: APjAAAUUlNwGdl6G7pGGoBCb/MAUjQ+lN7EHW9s15mx1QkIVbNkjb5QY fe60mL52Cmw1ZHI1lPLnmqzU6nay X-Google-Smtp-Source: APXvYqwsbV2CD8tmGJ2QzCZv81OWyuiF0+f0HrFtqixhi538D8rDZ+9EKzno+ba5nprD7p9EXMJ4Pg== X-Received: by 2002:a6b:cd03:: with SMTP id d3mr16677829iog.38.1552256205145; Sun, 10 Mar 2019 15:16:45 -0700 (PDT) Received: from titan.knownspace (173-25-245-129.client.mchsi.com. [173.25.245.129]) by smtp.gmail.com with ESMTPSA id u196sm8743241itu.34.2019.03.10.15.16.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 10 Mar 2019 15:16:44 -0700 (PDT) Date: Sun, 10 Mar 2019 17:16:40 -0500 From: Justin Hibbits To: Alexey Dokuchaev Cc: Justin Hibbits , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344960 - head/sys/powerpc/powerpc Message-ID: <20190310171640.31bb9c54@titan.knownspace> In-Reply-To: <20190309085058.GA60945@FreeBSD.org> References: <201903090318.x293IcLc023548@repo.freebsd.org> <20190309085058.GA60945@FreeBSD.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; powerpc64-portbld-freebsd13.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8A55269FCA X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Xvs/yOVM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of chmeeedalf@gmail.com designates 2607:f8b0:4864:20::d29 as permitted sender) smtp.mailfrom=chmeeedalf@gmail.com X-Spamd-Result: default: False [-6.69 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-2.72)[ip: (-8.74), ipnet: 2607:f8b0::/32(-2.74), asn: 15169(-2.07), country: US(-0.07)]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[9.2.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.96)[-0.958,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_LAST(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Mar 2019 22:16:47 -0000 On Sat, 9 Mar 2019 08:50:58 +0000 Alexey Dokuchaev wrote: > On Sat, Mar 09, 2019 at 03:18:38AM +0000, Justin Hibbits wrote: > > New Revision: 344960 > > URL: https://svnweb.freebsd.org/changeset/base/344960 > > > > Log: > > powerpc: Print trap frame address for fatal traps > > > > MFC after: 1 week > > > > Modified: > > head/sys/powerpc/powerpc/trap.c > > > > Modified: head/sys/powerpc/powerpc/trap.c > > ============================================================================== > > --- head/sys/powerpc/powerpc/trap.c Sat Mar 9 03:15:09 > > 2019 (r344959) +++ head/sys/powerpc/powerpc/trap.c > > Sat Mar 9 03:18:37 2019 (r344960) @@ -546,6 +546,7 @@ > > printtrap(u_int vector, struct trapframe *frame, int i printf(" > > current msr = 0x%" PRIxPTR "\n", mfmsr()); printf(" > > lr = 0x%" PRIxPTR " (0x%" PRIxPTR ")\n", frame->lr, > > frame->lr - (register_t)(__startkernel - KERNBASE)); > > + printf(" frame = %p\n", frame); > > printf(" curthread = %p\n", curthread); > > Some of those are printed with %PRIxPTR, some with %p. Perhaps this > inconsistency can be avoided? > > ./danfe PRIxPTR is for printing a pointer-like value that's not a pointer. The other values printed are of type register_t, not void *. - Justin