From owner-svn-src-all@freebsd.org Thu Apr 20 07:31:17 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 91CDDD471B9; Thu, 20 Apr 2017 07:31:17 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6D9D013B6; Thu, 20 Apr 2017 07:31:17 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 7E6ED10A82D; Thu, 20 Apr 2017 03:31:16 -0400 (EDT) From: John Baldwin To: rgrimes@freebsd.org Cc: Slawa Olhovchenkov , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r317094 - head/share/mk Date: Wed, 19 Apr 2017 12:38:54 -0700 Message-ID: <2211685.c7RPlKUNz2@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-STABLE; KDE/4.14.10; amd64; ; ) In-Reply-To: <201704191633.v3JGXWmu031427@pdx.rh.CN85.dnsmgr.net> References: <201704191633.v3JGXWmu031427@pdx.rh.CN85.dnsmgr.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Thu, 20 Apr 2017 03:31:16 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Apr 2017 07:31:17 -0000 On Wednesday, April 19, 2017 09:33:32 AM Rodney W. Grimes wrote: > > On Wednesday, April 19, 2017 01:28:37 AM Slawa Olhovchenkov wrote: > > > On Tue, Apr 18, 2017 at 12:45:25PM -0700, John Baldwin wrote: > > > > > > > On Tuesday, April 18, 2017 07:30:13 PM Slawa Olhovchenkov wrote: > > > > > On Tue, Apr 18, 2017 at 04:27:48PM +0000, John Baldwin wrote: > > > > > > > > > > > Author: jhb > > > > > > Date: Tue Apr 18 16:27:48 2017 > > > > > > New Revision: 317094 > > > > > > URL: https://svnweb.freebsd.org/changeset/base/317094 > > > > > > > > > > > > Log: > > > > > > Disable in-tree GDB by default on x86, mips, and powerpc. > > > > > > > > > > > > GDB in ports contains all of the functionality as GDB in base > > > > > > (including kgdb) for these platforms along with additional > > > > > > functionality. In-tree GDB remains enabled on ARM and sparc64. > > > > > > GDB in ports does not currently support kernel debugging on arm, > > > > > > and ports GDB for sparc64 has not been tested (though it does > > > > > > include sparc64 support). > > > > > > > > > > > > Reviewed by: bdrewery, emaste, imp > > > > > > Relnotes: yes > > > > > > Sponsored by: DARPA / AFRL > > > > > > Differential Revision: https://reviews.freebsd.org/D10399 > > > > > > > > > > Generating core.txt now complety broken? > > > > > > > > No. crashinfo has supported gdb from ports for quite a while now. > > > > If you 'pkg install gdb' crashinfo defaults to using the ports gdb over > > > > the base one already. > > > > > > I am about clean install, w/o ports. > > > > Until we get some sort of klldb support that will not work. However, > > we already have platforms now where /usr/bin/gdb doesn't work for that. > > riscv and aarch64 aren't supported in ancient gdb, and the MIPS > > /usr/bin/gdb didn't really work for me in my testing. > > So we break what worked on a Tier1 Platform? With my "user" hat on > these are the exact kind of breakages that send me looking for another > platform to run on. We far to often just go oh you can do X y and Z > to get around what we broke forgetting that the user 6 months from now > when this hits a release isnt gona come ask, he may just go down the > road to something else. > > Remove gdb WHEN klldb can replace it, not a day before. Using "oh its > broken on aarch64 and mips" is not a reason to break things on i386/amd64. /usr/bin/gdb is replaced by gdb from ports. /usr/bin/gdb in base will never get updated and will continue to rot. gdb from ports includes full kgdb support (and crashinfo will use it when available). gdb from ports also includes things like handling inline functions, AVX, fork following, support for threads for compat32 binaries, and cross-debugging of crash dumps (so you can debug a MIPS vmcore on an amd64 host) which /usr/bin/gdb will never be able to do. > Yes, I know we want to get gnu stuff out of the tree, but that needs > to come AFTER a proper replacement is avaliable. In this case the replacement is available as a package. GPLv2 gdb is orphaned and not maintained by anyone. -- John Baldwin