Date: Sat, 22 May 2004 10:55:12 +0200 From: Florent Thoumie <flz@xbsd.org> To: Pav Lucistnik <pav@FreeBSD.org> Cc: h2g2_jimmiejaz@yahoo.com Subject: Re: ports/66953: security/nikto doesn't install docs. Message-ID: <40AF1570.6050405@xbsd.org> In-Reply-To: <200405212240.i4LMeBPO032325@freefall.freebsd.org> References: <200405212240.i4LMeBPO032325@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Pav Lucistnik wrote: > Synopsis: security/nikto doesn't install docs. > > State-Changed-From-To: open->closed > State-Changed-By: pav > State-Changed-When: Fri May 21 15:39:59 PDT 2004 > State-Changed-Why: > Committed with some modifications, thank you! > > http://www.freebsd.org/cgi/query-pr.cgi?pr=66953 It seems like comments on PORTDOCS are very accurate. I read : # PORTDOCS - A list of files and directories relative to DOCSDIR. # Shell glob patterns can be used, directories include # the entire subtree of contained files and directories. # Should not be set when no documentation files are # installed (for example because NOPORTDOCS is defined). # Useful for dynamically generated documentation. I understand DOCSDIR should be set only if NOPORTDOCS is _not_ defined, for example like this : .if !defined(PORTDOCS) PORTDOCS=nikto_usage.txt nikto_usage.html CHANGES.txt README_plugins.txt .endif I think the comment should be modified, saying that PORTDOCS is automagically added to the package list (I didn't know it until clement@ committed my last port submission). Maybe should we add a new target for the docs to be installed in the same time. Something like : .if !target(install-docs) install-docs: @${MKDIR} ${DOCSDIR} .for i in ${PORTDOCS} @${INSTALL_DATA} ${WRKSRC}/docs/${i} ${DOCSDIR} .endfor .endif A lot of ports are installing their documentation this way. I'll send a PR, if you think it's a good idea. -- Florent Thoumie Epita SRS Promo 2005 web : http://xbsd.org/~flz Xbsd.org System Administrator mail : flz@xbsd.org work : (33 1) xxxxxxxx alt : flz@epita.fr home : (33 1) 34162095 gpg : 1024D/ADF908C1 cell : (33 6) 76088660
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40AF1570.6050405>