From owner-cvs-src@FreeBSD.ORG  Tue Aug  9 04:39:52 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id ADAE316A423
	for <cvs-src@FreeBSD.org>; Tue,  9 Aug 2005 04:39:52 +0000 (GMT)
	(envelope-from dougb@FreeBSD.org)
Received: from mail1.fluidhosting.com (mail1.fluidhosting.com [204.14.90.61])
	by mx1.FreeBSD.org (Postfix) with SMTP id 5E3A143D53
	for <cvs-src@FreeBSD.org>; Tue,  9 Aug 2005 04:39:51 +0000 (GMT)
	(envelope-from dougb@FreeBSD.org)
Received: (qmail 42150 invoked by uid 399); 9 Aug 2005 04:39:50 -0000
Received: from 69-175-228-47.vnnyca.adelphia.net (HELO ?192.168.1.101?)
	(dougb@dougbarton.net@69.175.228.47)
	by mail1.fluidhosting.com with SMTP; 9 Aug 2005 04:39:50 -0000
Message-ID: <42F83391.3080503@FreeBSD.org>
Date: Mon, 08 Aug 2005 21:39:45 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Mozilla Thunderbird 1.0.6 (X11/20050726)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
References: <200508080946.j789kAS0007023@repoman.freebsd.org>
In-Reply-To: <200508080946.j789kAS0007023@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/etc/rc.d cleanvar
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Aug 2005 04:39:52 -0000

Pawel Jakub Dawidek wrote:
> pjd         2005-08-08 09:46:10 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     etc/rc.d             cleanvar 
>   Log:
>   Back-out previous commit - we need to skip logging socket when we start a
>   jail and external syslogd is listening in jail's chroot.
>   
>   Pointed out by: csjp
>   
>   While here, skip also "logpriv" socket.
>   
>   Revision  Changes    Path
>   1.10      +3 -0      src/etc/rc.d/cleanvar
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/src/etc/rc.d/cleanvar.diff?&r1=1.9&r2=1.10&f=h
> 

Thanks for this change, I agree with it. I would also counsel against 
deleting things from the rc.d scripts because we "always" do things in a 
certain order for two reasons. First, we may change the order, and we do. 
Second, users may change the order.

IMO, your observation was valid, but warranted a comment in the script, not 
removal of the test.

hth,

Doug

-- 

     This .signature sanitized for your protection