From owner-freebsd-usb@FreeBSD.ORG  Sat Feb 13 16:48:02 2010
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B27561065672
	for <freebsd-usb@freebsd.org>; Sat, 13 Feb 2010 16:48:02 +0000 (UTC)
	(envelope-from freebsd-usb@dino.sk)
Received: from loki.netlab.sk (ns3.netlab.sk [84.245.65.11])
	by mx1.freebsd.org (Postfix) with ESMTP id 310BB8FC17
	for <freebsd-usb@freebsd.org>; Sat, 13 Feb 2010 16:48:01 +0000 (UTC)
Received: from via.dino.sk (fw1.dino.sk [84.245.95.252])
	(AUTH: PLAIN milan, TLS: TLSv1/SSLv3,256bits,AES256-SHA)
	by loki.netlab.sk with esmtp; Sat, 13 Feb 2010 17:47:30 +0100
	id 0002E0E3.4B76D7A2.000127AA
From: Milan Obuch <freebsd-usb@dino.sk>
To: Hans Petter Selasky <hselasky@c2i.net>
Date: Sat, 13 Feb 2010 17:47:47 +0100
User-Agent: KMail/1.9.10
References: <201002101050.08302.freebsd-usb@dino.sk>
	<201002131630.06417.freebsd-usb@dino.sk>
	<201002131713.02782.hselasky@c2i.net>
In-Reply-To: <201002131713.02782.hselasky@c2i.net>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <201002131747.48367.freebsd-usb@dino.sk>
Cc: freebsd-usb@freebsd.org
Subject: Re: Huawei E1752 under FreeBSD
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Feb 2010 16:48:02 -0000

On Saturday 13 February 2010 17:13:02 Hans Petter Selasky wrote:
> On Saturday 13 February 2010 16:30:05 Milan Obuch wrote:
> > Milan Obuch
>
> Hi,
>
> Committed to USB P4:
>
> http://p4web.freebsd.org/chv.cgi?CH=174658
> http://perforce.freebsd.org/chv.cgi?CH=174658
>
> Please verify the commit. Thanks for your patch!
>
> --HPS

Everything looks OK, I just think there should not be a comma after last 
enumerated value in usb_msctest.h:

enum {
	MSC_EJECT_STOPUNIT,
	MSC_EJECT_REZERO,
	MSC_EJECT_ZTESTOR,
	MSC_EJECT_CMOTECH,
	MSC_EJECT_E1752,
};

(At least version before this change had not it there...)

Milan