Date: Thu, 14 Mar 2013 19:14:47 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Diane Bruce <db@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r314176 - in head/comms: . ebook2cwgui Message-ID: <20130314191447.GA51189@FreeBSD.org> In-Reply-To: <201303141849.r2EInGcW076055@svn.freebsd.org> References: <201303141849.r2EInGcW076055@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 14, 2013 at 06:49:16PM +0000, Diane Bruce wrote: > New Revision: 314176 > URL: http://svnweb.freebsd.org/changeset/ports/314176 > > +# $FreeBSD$ > +# Wrong header format. :( > +CATEGORIES= comms hamradio While `comms' already looks pretty weird for something which is "GUI front end" as a primary category, `hamradio' looks even more bogus. > +MAINTAINER= db@FreeBSD.org > +COMMENT= WxWidgets front end for ebooks2cw wxWidgets is spelled wrongly; also, "GUI front end for ..." would probably make a better description. > +MAN1= ebook2cwgui.1 > + > +USE_WX= yes > + > +PLIST_FILES= bin/ebook2cwgui > +PORTDOCS= * Knobs are pooly sorted (USE_WX should be before MAN1, as MAN1 is more package related, while USE_* guys are more about the build). > +do-install: > + @${INSTALL_SCRIPT} ${WRKSRC}/ebook2cwgui ${PREFIX}/bin/ebook2cwgui ^^^^^^^^^^^^ Could be dropped, same name as the source file. > + @${INSTALL_DATA} ${WRKSRC}/ebook2cwgui.1 ${MANPREFIX}/man/man1 We do not mute installation commands, btw (also for the above). > +.if !defined(NOPORTDOCS) ^^^^^ Bogus whitespace, and PORT_OPTIONS:MDOCS should be checked instead of NOPORTDOCS (with DOCS defined in OPTIONS_DEFINE). > + @${MKDIR} ${DOCSDIR} > +.for f in README COPYING ChangeLog ^^^^^^^^^ Bogus whitespace again. > + @${INSTALL_DATA} ${WRKSRC}/$f ${DOCSDIR}/$f ^^^ If target filename is that same as source one, it can be omitted (noted earlier). > +.endfor COPYING is being installed as docs (which is wrong), but LICENSE is not being defined? Also, I would suggest converting `.for .. .endfor' loop into this: PORTDOCS= README ChangeLog ${INSTALL_DATA} ${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR} This is quite standard practice throughout the tree, and does not sacrifice readability while being nicely concise. > @@ -0,0 +1,6 @@ > +ebook2cwgui is a GUI front end for ebook2cw created in WxWidgets with Stray space at EOL. > +support for both Linux and Windows. This could probably confuse FreeBSD users. :) > +Written by Fabian Kurz, DJ1YFK <mail@fkurz.net> We usually abstain from explicitly crediting author in pkg-descr, but this point it moot, and I don't have very strong feeling about it. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130314191447.GA51189>