From owner-freebsd-arm@freebsd.org Mon Dec 2 13:53:09 2019 Return-Path: Delivered-To: freebsd-arm@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8BAA31AAA0B for ; Mon, 2 Dec 2019 13:53:09 +0000 (UTC) (envelope-from melounmichal@gmail.com) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47RRQX5LVwz3NXQ for ; Mon, 2 Dec 2019 13:53:08 +0000 (UTC) (envelope-from melounmichal@gmail.com) Received: by mail-wm1-x343.google.com with SMTP id t14so5875190wmi.5 for ; Mon, 02 Dec 2019 05:53:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:reply-to:subject:to:cc:references:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language; bh=CuLRiUr95THl62FLvgKd/dFbFXerHT36aceO0P6PuvA=; b=PLs0OH/8V2XsUJDwGl4jerx7mVfQWygE4kwJbMTtqF/UO5YlLKD7jh55TSDrfLU4+G k+L7GiZF0zuP+ZBaQNj3LCclmozafP2cFr63xGBuzTiGaJ1mmK693LfM0NPjxlH+ML/G E6IcstorM5aoDTB8Nr6Et2tYY4G7PlYldrD2+ocFngIornbWCuVU+fdggAIib9Xa4N9H bg9KBVuwUsVns4chCFK1lRp0fFBcjzH6yb0cxHX0GNy+8ON2BdRLP6OfFGeZxDF5Il/k iJfSFZd+DfDJG6dL9YE4oaX7rgDkGraiLlrBbXJTVZNbH5GNXUVnCpPDzp/GK1BUXHU3 TOuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:reply-to:subject:to:cc:references :autocrypt:message-id:date:user-agent:mime-version:in-reply-to :content-language; bh=CuLRiUr95THl62FLvgKd/dFbFXerHT36aceO0P6PuvA=; b=dk3Jxy8CtfTI7nlnPPLSJxM3qUh3+nItRTY8MTsA0iPqaVXkIZeBjKizhxrdrt90AN rDfBqJO0N2t+B1nfa6GzB3GzEpFOo6Ci5Gw9pRXuIu4GXDtnvWX6n2Qp4D0pW/jI5qqp F/1p/WmImVOIVabvXadKoRCnJEKpKe7lSrQrFiKm+eURONFFfXBrnhFxFOTPOJWTKA7t f0acG9bwQ8cq22G8oyDDKOMa0dWbvhVsKSyteDL3oNC51EG/v97lE/K3dx1mR8AGMh11 vrUYV9uHpIZt9NpytQVA+SGqxd4yayZ/x6mk1q/kXGdyhHgBzTOC9aCNZpoLraM61bx6 z6Rw== X-Gm-Message-State: APjAAAUfyvvooPrBmIqLhMJkElD3wanRzEtGTrHdB9uNWc9D2T+Q7EVj iRnyPZrShaAt8Bwq5uRxE7r5WP0Z X-Google-Smtp-Source: APXvYqyTB23pMi5WctDQ0ePm+8FKf5vYaYNLm57ozHwp3E5QiP8/JAzhZhGdAvgZvtoAmzALSgu0IA== X-Received: by 2002:a05:600c:1007:: with SMTP id c7mr5281689wmc.158.1575294787184; Mon, 02 Dec 2019 05:53:07 -0800 (PST) Received: from [88.208.79.100] (halouny.humusoft.cz. [88.208.79.100]) by smtp.gmail.com with ESMTPSA id h8sm23746276wrx.63.2019.12.02.05.53.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Dec 2019 05:53:06 -0800 (PST) Sender: Michal Meloun From: Michal Meloun X-Google-Original-From: Michal Meloun Reply-To: mmel@freebsd.org Subject: Re: rk_tsadc breaks (my) Rock64 To: Emmanuel Vadot , Peter Jeremy Cc: freebsd-arm@freebsd.org References: <20191201110716.GA41224@server.rulingia.com> <20191202111322.GF37113@server.rulingia.com> <20191202140416.936a457adebce6fca1341b18@bidouilliste.com> Autocrypt: addr=mmel@freebsd.org; prefer-encrypt=mutual; keydata= xsBNBFYuVRkBCADZiwLCCne3wG9b9k+R2Neo5zVo2bLaZRfNNY/v9kg283i0sb1Da4EdEiNT 15El5UyozhphUIbIR/zrVpxF1TvvFdoCyzx6a68bNY2d9dBrDcNDZC+XnyDdHQoobN87DWT1 mRVkmbg9LHZ/SVUOkGYuWyE+8UYeDAcUizuXwSK5zFWmeTyIoWNa68ifrWLfQe0p4x5jC/AI VURCi17p360vU4fhgwoMvEEhrRBWCr4DYHToFjIt2WdBy3GR1qoO0+Xkd6G+OoBULo+XDfgu L2WdPvh0K69F9/LgHkMmG5Il7SCe62QGpG2vaCgRV7BQhLX+kxlvM+WrdRatWRml4Y/3ABEB AAHNIE1pY2hhbCBNZWxvdW4gPG1tZWxAZnJlZWJzZC5vcmc+wsCuBBMBCgBBAhsDBQsJCAcD BRUKCQgLBRYDAgEAAh4BAheAAhkBFiEEAN1KEEuAn+Apg413aR6ya17FqqoFAlw3aO8FCQ9v FVYAIQkQaR6ya17FqqoWIQQA3UoQS4Cf4CmDjXdpHrJrXsWqqsgXB/9X81G4C63DVxn8dELB +nTQpj7yDvfQrA5oAyE9i+ry2p/ySsPCEVFa32zgNJVNUlQLZ1FlrmDUxLvuJAv9ZbMFSEmP utbi4ylwqmLtReLTrSwqucT7VkG9qcbxgIxMcrFCBAMPRwGqzI4B+tID4/LJrf8fICHW++NB l+7m9bEDVfk1fmXkq2iemsn7JtVpzA5bfjJ9ZJf6dzHTz0mlSSd6cZ0j6BWgp9rq6H/xiIJl MjmmjEG22s4Hw0Z/KVOxNNNvDamSKt5WRzzuqr74j1sE21OpY5mMH/coFR3irW94RRrgxLrd Na0C9wRyzEeIG/gAfqek87+I/Jy4YaGqV1PUzsBNBFYuVRkBCAC6oEZH0ttQ/zqlhPZl34dm yI66fbgvE9DAropm7KwHSyjTaKxrtpxPq3m4F/J+Z2DN++xzp2pTxsjrl7wm0PDBVUXVjh8X pyY1yYmpTXQbDn9sC72t70klbHaD84m1gyHCaoQTkNxLobCC8lkj72GChIsveZn4aw7bk0zg GFUfWjUAThDc7QdkwycjMf6mZrRq6BldzdB6nXv85xz7UDvERufxUBjHxzCORhTLsnK9XHh5 y6P6L66gJeE2FflB0hyfhQxPXbfcFx3JVm1mwtMjboHIWauq4aOSY37+Gtr+z6cp9x6A4p4d ZVj+4WANGTRMRh3pC511lajv5cxkumzBABEBAAHCwGUEGAEKAA8CGwwFAlmMEcMFCQcgI6oA CgkQaR6ya17Fqqq7Kwf+IOBEiuUy8VMYvKS1nCz8r8LTeBZn+1bAlXn5IWpGhqwz5n735xvj hcDetF6qJ4uxgXmpJdNccE+ESDX71X0oQ8unB6S0u0C/zPKc37pVV9/DJFZDg8hmYcIxPo8k /5GTQNTpWsNzdyHnx6t267JEOxuHfaD3qdgw28OwuEO+rjgY8ct+CVQdFjrAejcjEAfYeixp Y0LXRHXclKsJ0Wc8x4hr6dIT7XWEB0GZam4+BVfZU0Su2vBIGvsuzIJnjIs7Rs3l8ozT9Nq9 z0Rwj2oMGue2z8R9mgIeEO1MwQWdBkzJuwyyjbQj+fFg8W5a64Wfu5B6hivBbG3XlKQ3RGC1 XcLAkwQYAQoAJgIbDBYhBADdShBLgJ/gKYONd2kesmtexaqqBQJcN2mbBQkPbxYCACEJEGke smtexaqqFiEEAN1KEEuAn+Apg413aR6ya17FqqrTqwf/TpJP3Ztv5gLN7WwOpZSjmQMH1MAa J8Bu2ISvXTm+TaP2yaGPBvbNiFV6sFiqgg79aiguDPKTFzw/X1bHzTxvBgNRma6WaGcRxbXl 2R6BNYK6VsqRNE94adVtIUDVlyr9DErhDEVSlNZv4si2tdF+6vAWirRA7N+V3wwoe3lYNb6o irVshZ9bvsvRstWbXP0ik7PJkLzGDVHQWblerzdFUs9yOsA/R1X6OhKNzO3FaaqkPioa6xog gmED32cKRQCUkoFd20eTtAZTWhiiTqFU1dcnsUW1RErbMIhT/CRUKelPkt56hBRaG+3WkAS8 YvNKFFUZ+nhHc0fLQYSMu7G3gw== Message-ID: Date: Mon, 2 Dec 2019 14:53:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191202140416.936a457adebce6fca1341b18@bidouilliste.com> Content-Type: multipart/mixed; boundary="------------2008DF11CC7EBBE6A82A354C" Content-Language: en-US X-Rspamd-Queue-Id: 47RRQX5LVwz3NXQ X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=PLs0OH/8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of melounmichal@gmail.com designates 2a00:1450:4864:20::343 as permitted sender) smtp.mailfrom=melounmichal@gmail.com X-Spamd-Result: default: False [-1.90 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[mmel@freebsd.org]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; HAS_ATTACHMENT(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; CTYPE_MIXED_BOGUS(1.00)[]; MIME_BASE64_TEXT(0.10)[]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/mixed,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-arm@freebsd.org]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[3.4.3.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (3.09), ipnet: 2a00:1450::/32(-2.69), asn: 15169(-1.94), country: US(-0.05)]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Dec 2019 13:53:09 -0000 This is a multi-part message in MIME format. --------------2008DF11CC7EBBE6A82A354C Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 02.12.2019 14:04, Emmanuel Vadot wrote: > On Mon, 2 Dec 2019 22:13:22 +1100 > Peter Jeremy wrote: > >> On 2019-Dec-01 22:07:16 +1100, Peter Jeremy wrote: >>> r355173 added code to read the Rockchip temperature sensors. Unfortunately, >>> this breaks on my Rock64. I've tried to understand what's going wrong but >>> haven't managed to make much headway. It looks like there some configuration >>> missing from syscon that tsadc needs but I'm not sure what (and I don't really >>> understand what syscon is doing). I'd appreciate any insights. >> >> I've added a pile of printf's and done some more digging and have made some >> progress. >> >> Firstly, I've found that the syscon@ff100000 FDT entry attaches as two >> distinct devices: >> rk_grf0: mem 0xff100000-0xff100fff on ofwbus0 >> (via compatible = "rockchip,rk3328-grf") >> simple_mfd0: mem 0xff450000-0xff45ffff on ofwbus0 >> (via compatible = "simple-mfd") > > ??? those aren't the same devices. > >> Based on the traceback going via simple_mfd_syscon_write_4(), I had assumed >> that tsadc_attach() was using the latter device but when I added code to >> print structure addresses, I discovered it was the former. >> >> This makes the problem clearer: rk_grf0 requests and is allocated 4KiB >> memory ("reg = <0x0 0xff100000 0x0 0x1000>;" in the FDT and >> "mem 0xff100000-0xff100fff" in the device attach message above) but the >> tsadc_init() code is doing: >> SYSCON_WRITE_4(sc->grf, GRF_TSADC_TESTBIT_L, >> GRF_TSADC_VCM_EN_L); >> with >> #define GRF_TSADC_TESTBIT_L 0x0e648 >> and that offset is well outside the 4KiB allocated to the device. >> (On the positive side, a panic makes the problem a lot clearer than >> writing to a random device location would have been). >> >> Ganbold's followup shows that the RK3399 allocates 64KiB to the syscon >> device so the equivalent write is valid on a RK3399. >> >> I suspect the problem is that the following defines are only valid for >> the RK3399 since I can't find any matches to either the names or offsets >> in the following: >> #define GRF_SARADC_TESTBIT 0x0e644 >> #define GRF_TSADC_TESTBIT_L 0x0e648 >> #define GRF_TSADC_TESTBIT_H 0x0e64c >> >> Unfortunately, that also means I currently have no idea what the RK3328 >> equivalents to those offsets are. >> >> -- >> Peter Jeremy > > root@rock64:~ # uname -a > FreeBSD rock64.home.blih.net 13.0-CURRENT FreeBSD 13.0-CURRENT #13 r355188:355190M: Thu Nov 28 21:43:00 CET 2019 manu@skull.home.blih.net:/usr/home/manu/Work/freebsd/obj/usr/home/manu/Work/freebsd/freebsd-svn/base/head/arm64.aarch64/sys/GENERIC arm64 > root@rock64:~ # sysctl hw.temperature > hw.temperature.CPU: 50.7C > > Everything is working for me after I've added the clocks, so I don't > know what's happening for you. But after looking again at the docs it > seems that rk3328 is a mix between v2 and v3 so the GRF write are wrong. > I'll have a look today or tomorow and fix this. > Peter, can you please try following trivial patch? Michal --------------2008DF11CC7EBBE6A82A354C Content-Type: text/plain; charset=UTF-8; name="tsaadc_fix.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="tsaadc_fix.diff" ZGlmZiAtLWdpdCBhL3N5cy9hcm02NC9yb2NrY2hpcC9ya190c2FkYy5jIGIvc3lzL2FybTY0 L3JvY2tjaGlwL3JrX3RzYWRjLmMKaW5kZXggNzQ0ZGMxYjhhZmIuLjk5NGQ0ZTE3NmU4IDEw MDY0NAotLS0gYS9zeXMvYXJtNjQvcm9ja2NoaXAvcmtfdHNhZGMuYworKysgYi9zeXMvYXJt NjQvcm9ja2NoaXAvcmtfdHNhZGMuYwpAQCAtMjQxLDcgKzI0MSw3IEBAIHN0YXRpYyBzdHJ1 Y3QgdHNlbnNvciByazMzMjhfdHNlbnNvcnNbXSA9IHsKIH07CiAKIHN0YXRpYyBzdHJ1Y3Qg dHNhZGNfY29uZiByazMzMjhfdHNhZGNfY29uZiA9IHsKLQkudHlwZSA9IAkJUktfVFNBRENf VjMsCisJLnR5cGUgPSAJCVJLX1RTQURDX1YyLAogCS5zaHV0ZG93bl90ZW1wID0JOTUwMDAs CiAJLnNodXRkb3duX21vZGUgPQkwLCAvKiBDUlUgKi8KIAkuc2h1dGRvd25fcG9sID0JCTAs IC8qIExvdyAgKi8K --------------2008DF11CC7EBBE6A82A354C--