From owner-freebsd-current@FreeBSD.ORG Tue Jan 31 18:42:24 2006 Return-Path: X-Original-To: freebsd-current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9883C16A420; Tue, 31 Jan 2006 18:42:24 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5018343D46; Tue, 31 Jan 2006 18:42:24 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id 394501A3C22; Tue, 31 Jan 2006 10:42:24 -0800 (PST) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 8A7825125B; Tue, 31 Jan 2006 13:42:23 -0500 (EST) Date: Tue, 31 Jan 2006 13:42:23 -0500 From: Kris Kennaway To: Pawel Jakub Dawidek Message-ID: <20060131184223.GC10257@xor.obsecurity.org> References: <200601311109.k0VB9MRq025366@repoman.freebsd.org> <20060131151809.GE83051@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DSayHWYpDlRfCAAQ" Content-Disposition: inline In-Reply-To: <20060131151809.GE83051@garage.freebsd.pl> User-Agent: Mutt/1.4.2.1i Cc: kris@FreeBSD.org, freebsd-current@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_malloc.c src/share/man/man9 Makefile redzone.9 src/sys/vm redzone.c redzone.h src/sys/conf NOTES files options X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jan 2006 18:42:24 -0000 --DSayHWYpDlRfCAAQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 31, 2006 at 04:18:09PM +0100, Pawel Jakub Dawidek wrote: > On Tue, Jan 31, 2006 at 11:09:22AM +0000, Pawel Jakub Dawidek wrote: > +> pjd 2006-01-31 11:09:22 UTC > +>=20 > +> FreeBSD src repository > +>=20 > +> Modified files: > +> sys/kern kern_malloc.c=20 > +> share/man/man9 Makefile=20 > +> sys/conf NOTES files options=20 > +> Added files: > +> share/man/man9 redzone.9=20 > +> sys/vm redzone.c redzone.h=20 > +> Log: > +> Add buffer corruption protection (RedZone) for kernel's malloc(9). > +> It detects both: buffer underflows and buffer overflows bugs at runt= ime > +> (on free(9) and realloc(9)) and prints backtraces from where memory = was > +> allocated and from where it was freed. > +> =20 > +> Tested by: kris >=20 > As I noted above, Kris did some tests with redzone(9) enabled and haven't > found any issues. >=20 > We may want to turn it on in HEAD by default for some time, so more code > can be tested. >=20 > What do you think? Kris, is there visible overhead with redzone(9)? I haven't really tested that, but it doesn't seem too bad. I think it would be well worth leaving it on for a while to see what turns up though. Kris --DSayHWYpDlRfCAAQ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFD36+OWry0BWjoQKURAlmUAJ9bNDspx3O9fZutQ4Gp61jJ/0powgCfUe42 f8jPHS3YWKU3ysQ5GSRmldA= =iv0m -----END PGP SIGNATURE----- --DSayHWYpDlRfCAAQ--