From owner-freebsd-current Tue Jul 30 8:28:40 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C037437B400; Tue, 30 Jul 2002 08:28:33 -0700 (PDT) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 587D843E3B; Tue, 30 Jul 2002 08:28:29 -0700 (PDT) (envelope-from ru@whale.sunbay.crimea.ua) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.6/8.11.2) id g6UFSEH23829; Tue, 30 Jul 2002 18:28:14 +0300 (EEST) (envelope-from ru) Date: Tue, 30 Jul 2002 18:28:14 +0300 From: Ruslan Ermilov To: Bruce Evans Cc: arch@FreeBSD.org, current@FreeBSD.org Subject: Re: install -d -C (was: Re: cvs commit: src/share/man/man5 make.conf.5 src/share/examples/etc make.conf) Message-ID: <20020730152814.GA23325@sunbay.com> References: <20020729094629.GA94086@sunbay.com> <20020730061741.S52629-100000@gamplex.bde.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="k+w/mQv8wyuph6w0" Content-Disposition: inline In-Reply-To: <20020730061741.S52629-100000@gamplex.bde.org> User-Agent: Mutt/1.3.99i Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --k+w/mQv8wyuph6w0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 30, 2002 at 06:21:17AM +1000, Bruce Evans wrote: > On Mon, 29 Jul 2002, Ruslan Ermilov wrote: >=20 > > On Fri, Jul 19, 2002 at 10:55:56PM +1000, Bruce Evans wrote: > > > On Fri, 19 Jul 2002, Ruslan Ermilov wrote: > > > > OTOH, if we go this way we can get rid of ugly ${COPY} completely. > > > > > > I'd like to get rid of it too. But not in RELENG_4. -c has been the= default > > > for long enough now in -current. As you know, there are various prob= lems > > > in using the correctly named variable for install(1)'s flags (INSTALL= FLAGS) > > > to actually hold install's flags in a general way (mainly, this varia= ble > > > already exists and is used in a non-general way). However, the old h= ack > > > of putting the flags in the same variable as the command still works = well > > > except for the -[Cp] vs -d conflict. This depends on the flags not b= eing > > > order-dependent. > > > > > OK, -[CpS] are now ignored with -d, and I've dropped support for COPY. > > I have a question. Why COPY can't be removed from RELENG_4 as well? > > Ports that use COPY (there are many of them) will see it as an empty > > string. >=20 > -c hasn't been the default for so long in RELENG_4, so I think the change > has too lrge a risk/reward ratio. >=20 Can you envision any breakage caused by me removing COPY?=3D-c from RELENG_4's bsd.own.mk? We bootstrap install(1), so it's in my opinion safe to assume that on a system without COPY in bsd.own.mk install(1) copies files by default, no? bsd.port.mk and many ports that use ${COPY} will substitute an empty string. If you disagree, what do you propose? Remove any usages of COPY from src/ and leave its definition in bsd.own.mk? What purpose would it serve then? Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age --k+w/mQv8wyuph6w0 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iD8DBQE9RrCOUkv4P6juNwoRAucgAJsF1UgWuU3pOiBa3lEZUb4C/0sqNwCeO762 2JBWrZnIHGT3Q4TYsJKomw4= =O3br -----END PGP SIGNATURE----- --k+w/mQv8wyuph6w0-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message