From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jun 25 12:50:09 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4C5EF106567E for ; Mon, 25 Jun 2012 12:50:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 1F8378FC1D for ; Mon, 25 Jun 2012 12:50:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q5PCo8g2077781 for ; Mon, 25 Jun 2012 12:50:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q5PCo8gX077780; Mon, 25 Jun 2012 12:50:08 GMT (envelope-from gnats) Resent-Date: Mon, 25 Jun 2012 12:50:08 GMT Resent-Message-Id: <201206251250.q5PCo8gX077780@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Alexander Pronin Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 505AB106564A for ; Mon, 25 Jun 2012 12:48:30 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 274748FC2B for ; Mon, 25 Jun 2012 12:48:30 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q5PCmTd5031210 for ; Mon, 25 Jun 2012 12:48:29 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q5PCmTig031209; Mon, 25 Jun 2012 12:48:29 GMT (envelope-from nobody) Message-Id: <201206251248.q5PCmTig031209@red.freebsd.org> Date: Mon, 25 Jun 2012 12:48:29 GMT From: Alexander Pronin To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/169394: [ bsd.port.mk ] improper evaluation of config-recursive target X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jun 2012 12:50:09 -0000 >Number: 169394 >Category: ports >Synopsis: [ bsd.port.mk ] improper evaluation of config-recursive target >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Mon Jun 25 12:50:08 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Alexander Pronin >Release: 9.0 >Organization: >Environment: FreeBSD freebsd-STABLE 9.0-STABLE FreeBSD 9.0-STABLE #0 r234953: Fri May 4 10:53:12 MSK 2012 scher@freebsd-STABLE:/usr/obj/usr/src/sys/GENERIC amd64 >Description: It is assumed that if a user calls %make config-recursive then options of current port and all it's dependency ports will be processed, but If this port(A) enables dependency port(Z) via options then $$(${ALL-DEPENDS-LIST}) will not include this port(Z), hence options of port(Z) will not be processed. If dependency port(B) of port(A) enables another dependency port(X) then options of this port(X) will not be processed either. >How-To-Repeat: >Fix: --- /Users/scher/tmp/config-recursive/bsd.port.mk 2012-06-21 22:53:45.000000000 +0400 +++ /Users/scher/tmp/config-recursive/bsd.port.mk-fixed 2012-06-21 22:54:35.000000000 +0400 @@ -6110,8 +6110,8 @@ .if !target(config-recursive) -config-recursive: +config-recursive: config-conditional @${ECHO_MSG} "===> Setting user-specified options for ${PKGNAME} and dependencies"; - @for dir in ${.CURDIR} $$(${ALL-DEPENDS-LIST}); do \ - (cd $$dir; ${MAKE} config-conditional); \ + @for dir in $$(${MAKE} run-depends-list build-depends-list | uniq); do \ + (cd $$dir; ${MAKE} config-recursive); \ done .endif # config-recursive Patch attached with submission follows: --- bsd.port.mk 2012-06-21 22:53:45.000000000 +0400 +++ bsd.port.mk-fixed 2012-06-25 16:43:58.000000000 +0400 @@ -6110,8 +6110,8 @@ .if !target(config-recursive) -config-recursive: +config-recursive: config-conditional @${ECHO_MSG} "===> Setting user-specified options for ${PKGNAME} and dependencies"; - @for dir in ${.CURDIR} $$(${ALL-DEPENDS-LIST}); do \ - (cd $$dir; ${MAKE} config-conditional); \ + @for dir in $$(${MAKE} run-depends-list build-depends-list | uniq); do \ + (cd $$dir; ${MAKE} config-recursive); \ done .endif # config-recursive >Release-Note: >Audit-Trail: >Unformatted: