From owner-svn-src-all@freebsd.org Sun Apr 19 22:54:30 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5C0EA2AD915 for ; Sun, 19 Apr 2020 22:54:30 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4954s05xpdz48Dc for ; Sun, 19 Apr 2020 22:54:28 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-ej1-x642.google.com with SMTP id s3so6361269eji.6 for ; Sun, 19 Apr 2020 15:54:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=y+5C500PqYPOl8OH7iHJ4mT4XJv2zqvGgG7OAbPhDnI=; b=JTvxosrvArbti4i1UivcOkCVEibITS1HjWdBm80ztAtq7Bx5PqVVyjJUz8cfOw9C0R 64pnv0MB6ROb2j/saX3gekjNzlIsXR1z2PWyOvPdwVF80i75/uiUmphh0/Z9cSeC0ycQ Jgvgu95nYyFICHLbwXNm7ZXUna4VbwmaIYiNDonlolEQXYXisYVAAIHsnsUI7EsWn3Z/ sggGUg/m2ihVghu9Th42REaike0m7arCb4GUQC5l74BL7rRzprk/LaEIv+i3YUDM8pFF EG8fkHNHGn0m0USF5PX3qhFGWaEjkj0iGUu2Ofnp+HGKCMvK+4diS6lt1IoxGXcvwEuO qTbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=y+5C500PqYPOl8OH7iHJ4mT4XJv2zqvGgG7OAbPhDnI=; b=LNNgWhiOMk96BrtttPzugAFMBVZ7JAWqP+e/W1MsJWD4f4j8GJ6xDyrphPMOSyRFym pCZ3008UokswJ5jccI4WRkmBP6rY1Prhij+5n44gtJcQ/EiJNTw622sDKRLbOfxnYUKV r4I0sereg2WmDr+vbVunLi5iXAetmxDMhKWyEUUsHqx5LC/+UspMcDzA7li79b2656rJ qwzX2wh5uUHYFmjtsokism3QRA0JTD/oSgpsQZE5ABbLtI0pXJqTyMtIjDe/ZIeFOu54 XYBfmi+RcKt05vdn2HWVR3+fmz05B40LY6Dy9M1IwTfT5F6ijT/MVIWsYhXVAakmwld7 oHdg== X-Gm-Message-State: AGi0PuaOqrObMMR7ihd3UN9kLKxtTgqOHYudVB581gXs5dePqpB6eiLL qsZJF2ULxxiG61qrDG8Xw4kgJGuAqmV7UUHy X-Google-Smtp-Source: APiQypLQllWvhrXzZ2mebXQw2SIvO3xlQq10rKmVxjRoIdqlPRrgkap4cH0IN+/FSVlvm1cs0yYJVg== X-Received: by 2002:a2e:9496:: with SMTP id c22mr7083264ljh.165.1587336444321; Sun, 19 Apr 2020 15:47:24 -0700 (PDT) Received: from mutt-hbsd ([185.220.101.11]) by smtp.gmail.com with ESMTPSA id z9sm29321541lfd.9.2020.04.19.15.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Apr 2020 15:47:23 -0700 (PDT) Date: Sun, 19 Apr 2020 18:47:13 -0400 From: Shawn Webb To: Conrad Meyer Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r359950 - head/usr.sbin/bhyve Message-ID: <20200419224713.xaxvnuo334v6bhtj@mutt-hbsd> X-Operating-System: FreeBSD mutt-hbsd 13.0-CURRENT-HBSD FreeBSD 13.0-CURRENT-HBSD X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0xFF2E67A277F8E1FA References: <202004150200.03F20I3H001953@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4fkv3lqg7o4odp2d" Content-Disposition: inline In-Reply-To: <202004150200.03F20I3H001953@repo.freebsd.org> X-Rspamd-Queue-Id: 4954s05xpdz48Dc X-Spamd-Bar: ++++++++++ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hardenedbsd.org header.s=google header.b=JTvxosrv; dmarc=none; spf=pass (mx1.freebsd.org: domain of shawn.webb@hardenedbsd.org designates 2a00:1450:4864:20::642 as permitted sender) smtp.mailfrom=shawn.webb@hardenedbsd.org X-Spamd-Result: default: False [10.02 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(0.00)[+ip6:2a00:1450:4000::/36:c]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[hardenedbsd.org:+]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-0.56)[ipnet: 2a00:1450::/32(-2.34), asn: 15169(-0.43), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RECEIVED_SPAMHAUS_PBL(0.00)[11.101.220.185.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_XBL(5.00)[11.101.220.185.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.4]; R_DKIM_ALLOW(0.00)[hardenedbsd.org:s=google]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; SH_AUTHBL_RECEIVED(4.00)[11.101.220.185.khpj7ygk5idzvmvt5x4ziurxhy.authbl.dq.spamhaus.net : 127.0.0.20]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[hardenedbsd.org]; NEURAL_SPAM_MEDIUM(0.11)[0.109,0]; BAD_REP_POLICIES(0.10)[]; RECEIVED_BLOCKLISTDE(3.00)[11.101.220.185.bl.blocklist.de]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(0.08)[0.078,0]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[]; GREYLIST(0.00)[pass,body] X-Spam: Yes X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Apr 2020 22:54:30 -0000 --4fkv3lqg7o4odp2d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 15, 2020 at 02:00:18AM +0000, Conrad Meyer wrote: > Author: cem > Date: Wed Apr 15 02:00:17 2020 > New Revision: 359950 > URL: https://svnweb.freebsd.org/changeset/base/359950 >=20 > Log: > bhyve(8): Add VM Generation Counter ACPI device > =20 > Add an implementatation of the 'Virtual Machine Generation ID' spec to > Bhyve. The spec provides a randomly generated GUID (at bhyve start) in > device memory, along with an ACPI device with _CID VM_Gen_Counter and A= DDR > evaluating to a Package pointing at that GUID. > =20 > A GPE is defined which Notifies the ACPI Device when the generation cha= nges > (such as when a snapshot is rolled back). At this time, Bhyve does not > support snapshotting, so the GPE is never actually raised. > =20 > Suggested by: rpokala > Discussed with: grehan > Differential Revision: https://reviews.freebsd.org/D23165 >=20 > Added: > head/usr.sbin/bhyve/vmgenc.c (contents, props changed) > head/usr.sbin/bhyve/vmgenc.h (contents, props changed) > Modified: > head/usr.sbin/bhyve/Makefile > head/usr.sbin/bhyve/acpi.c > head/usr.sbin/bhyve/acpi.h > head/usr.sbin/bhyve/bhyverun.c > head/usr.sbin/bhyve/pm.c Hey Conrad, Something about this commit broke bhyve in UEFI mode. Reverting this specific change caused bhyve to work again. Here's a sample command: /usr/obj/usr/src/amd64.amd64/usr.sbin/bhyve/bhyve \ -c 4 \ -m 16g \ -H \ -A \ -P \ -S \ -g 0 \ -s 0:0,hostbridge \ -s 1:0,lpc \ -s 29,fbuf,tcp=3D127.0.0.1:5910,w=3D1024,h=3D768,wait \ -l bootrom,/usr/local/share/uefi-firmware/BHYVE_UEFI.fd \ -s 2:0,virtio-net,tap1 \ -s 3:0,virtio-blk,/dev/zvol/rpool/bhyve/hbsd-cross-dso-cfi-01/disk-01 \ -l com1,/dev/nmdm-hbsd-cross-dso-cfi-01-A \ -s 31:0,ahci-cd,/ISO/HardenedBSD/12-stable_amd64/2020-04-19_disc1.iso \ hbsd-cdcfi-01 Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 https://git-01.md.hardenedbsd.org/HardenedBSD/pubkeys/src/branch/master/Sha= wn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --4fkv3lqg7o4odp2d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAl6c1OoACgkQ/y5nonf4 4fpmFBAAkIZ0yZKAVukQnHTTHYh961A5XaOde5uiCRBSAovpcC/lM1hzhx5wA9hj x4DktYszi4/IrQK7hQSkA/Iq3xOCKcmkdiH6gs8W0Mw3sGfwVO6t3u2+qnDNGnDJ me1GgykD0AX0zl0gACN0jM8566I3gGY2xuNUFY6W6Wzd969KNTvIfEDBlmTMFIr0 vWDdVBWl1YGa4ePgmHynjCM5X5JVkBwRWKwEqw+5yF5wfkqdxu6i4qW6uFbVdOJ6 imVinqbwaQP5bqx+7Ln3svLEhLaCwSvd0KVR2fqc/y8SEigc8ryqiAsirYnVRYD/ yk8mRm3PdQafbUJoilOooKzIf/7CbA+URj7QkpLBZr5y2BMW2rXFnIQgXFUEJ6Js bsUSMF31Vz2KZqD0N7RxFi0QHH5nawLY9ZSUWwWisldfmu2KsSuaDv73HAzp5ofu w5R1bYazLIem61Uiak+TwEQHTZxM9tbFOqtcrruIcKf0iCOZicregpb/ROXtpZPi ZMuy82ZpEI1V6lRqKonoa1bqoZJvk9q6Xz8KT/jRjSgeZanOZSZ+I1U2kWEfHx0c c9UngdJhIMWTZuuBPKC7fhd4MH/F1J76dIHeusybvv0FXiZ2BttTX2Iv55M8V6Mr XfyXBUxrcyPnEOrkjT4sklPe3pUbpEx8AJfx2Ac27LEN/MNGT2I= =/PtU -----END PGP SIGNATURE----- --4fkv3lqg7o4odp2d--